Bugs and Suggestions about msl-vscode-extension HOT 1 OPEN

Errors/Enhancements:

• switches
• on close channel target
• on topic targets
• ctcp event targets
• on open matching text
• $() as $eval identifier
• . on props should be highlighted
• timer name
• % and $ should be highlighted
• alias code block and code block end together
• commented }
• number ranges
• goto label
• number ranges (1-)
• bset text
• number highlighting inconsistent
• scon commands
• channel symbol to be treated as a special character/identifier

Notes:

1. We currently do not use a strict switches highlighting rule, we use a global rule so it takes into account commands that use switches that are separated by spaces and other arguments.
2. No documentation was found on having the channel symbol as a valid target on close event
3. Might not only be a problem for on topic because we use a non-variable/non-identifier friendly on the targets for events
4. Same as 3.
5. Currently grouped with the on close event, which does not require a matchtext argument
6. $() needs to be added as a valid identifier
7. To be consistent with the switches highlighting . should be added to the highlighting part
8. Unknown reason as to why it is not highlighting the last characters as the regex says to include non-space characters, might have to do with the (?=\b) flag
9. I do not agree with this as % and $ are not variables nor identifiers and should be treated as text only
10. Seems as if the if code block does not consume the } and the alias code block takes it
11. Single line comments are stopped when it finds a }
12. Highlighting number ranges is more of an enhancement rather than a bug
13. Same as 12.
14. Same as 12.
15. Same as 12.
16. Same as 1.
17. Unknown reason as to why is not highlighting the number, numbers are part of the constant group in the language file
18. Again, we are using more global rules to parse each command, we would need to add a specific rule for certain commands
19. Same as 12.

I believe we could split this issue into 2, one with all the bugs and another one with all the enhancements, as issues should take a different priority over enhancements.

from msl-vscode-extension.