Giter Club home page Giter Club logo

Comments (6)

Kedyn avatar Kedyn commented on September 26, 2024

The first link, brings out a few minor and big issues.

  1. A problem with events using variables.
  2. Well known issue with the $& identifier. (big issue)
  3. A problem with the single line comment ; and brackets { and }.

The second link, has to do with a missing ) on an $iif(, but if the script still works with said issue, we might have to look into it.

Although this currently affects both the highlighting here on GitHub and on VSCode, I believe this issue should be moved to only the highlighting here on GitHub repo because I still have planned to move away from regex (textmate) highlighting system for the extension in favor of semantic highlighting.

I do not have plans as to when I will start working on this, so for now I will keep this issue here, and will soon start fixing some of the minor bugs as soon as I can.

from msl-vscode-extension.

westor7 avatar westor7 commented on September 26, 2024

I thought https://github.com/Kedyn/language-msl was using this project stuff, so changes on this effecting the other.

from msl-vscode-extension.

Kedyn avatar Kedyn commented on September 26, 2024

Yes, that was the case, and in some way still is, but because this project will no longer be using regex. I think it would be best to keep them as separate things. I mean we could keep it as is, VSCode allows to have both and will prefer semantic highlighting over the textmate (regex). That being said, now I am thinking it wouldn't hurt to keep it as is, but maybe one will have issues that the other will not. What do you think?

from msl-vscode-extension.

westor7 avatar westor7 commented on September 26, 2024

I prefer to fix that on github side and then you can decide, because personally i think its more important to be correct on github that are hosted the most of the mSL codes, i think everything else needs to copy the github highlight to use in any other program/app but githubs syntax highlighting on mSL needs to be correct and up-to-date.

Ofc i can help you with that anytime :D

from msl-vscode-extension.

Kedyn avatar Kedyn commented on September 26, 2024

Agree, I have changed the readme on the https://github.com/Kedyn/language-msl repo. If you can contribute anything I will accept your pull request there. I will keep this issue open sense it is part of this project too.

from msl-vscode-extension.

westor7 avatar westor7 commented on September 26, 2024

Moved to #19

from msl-vscode-extension.

Related Issues (14)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.