minvws / puzi-laravel Goto Github PK

Feature request

When using this project in an implementation, I need to have an authenticatable user.
I do this by having App\Models\User extend \Illuminate\Foundation\Auth\User.
But this means that, when I want to store data from the UziUser, I need to inject the AuthenticatableUziUser as it is not a model.

Would it make sense to make MinVWS\PUZI\Laravel\AuthenticatableUziUser a model class by having it extend \Illuminate\Foundation\Auth\User?

This would allow extending the class if/when wanted. As far as I am aware, there are no downsides if the class is not extended.

In order to implement this, the AuthenticatableUziUser would need to have MinVWS\PUZI\UziUser injected (instead of extending it).

Thoughts?

Governance

• I've read the contributing document https://github.com/minvws/.github/blob/master/CONTRIBUTING.md
• I've read and understand the Code of Conduct https://github.com/minvws/.github/blob/master/CODE_OF_CONDUCT.md
• I understand that any contributions or suggestions I made may make it into the actual code. I've read the License https://github.com/minvws/nl-covid19-notification-app-coordination/blob/master/LICENSE.txt and the contributor license agreement https://github.com/minvws/nl-covid19-notification-app-coordination/blob/master/CLA.md