minevidold / dtltraders-plus- Goto Github PK

Hi

Please can you add more placeholders to auto generate into lore/item names, we have one for username of the buyer, could we please get one for Date/time of purchase.

Alternatively can you enable PlaceholderAPI support, then we can use any variable we want.

https://www.spigotmc.org/resources/imageonmap.26585/

I think I've reported this before, when you make a splatter map from "Image on map" plugin, save it in an NPC shop and restart that map is turned into a single map, not a splatter map any more, the additional data that makes it a splatter map must be lost at reboot.

DTL: 6.4.9
PurPur 1.18.1 (1563)

when the player sells an item to an npc the money doesnt add on the balance of the player

So we discovered that we can take items by using f / offhand button then using f/offhand to move to inventory or armour slot. These apply none of the perks the item should and if you click the item it dissapears but it would be nice to see this fixed.

Here is some photos for reference.

If you need a better explanation my discord is Smoke_Kush#1439.

Thanks.

If you have a shop set to an NPC and you delete a shop in the GUI, the NPC will still have its trait.
This should automatically be removed when you delete a shop.
I found out that you have to manually run /trait remove trader with the exact name of the shop as the trait separate.
This could easily be done automatically.

Allow us to "Deactivate" or "Hide" pages, so then we can have event based things that we can set into hide/deactivated mode so its not shown to players.

Not sure if this is StructureBoxes or dtlTraders or just a conflict;
Using Paper 1.12.2 just having the plugin on the server spams the console every second.
https://gist.github.com/TomLewis/0f1ec54d7ca92fbf3f749a3326b6f21d

Also reported for StructureBoxes
eirikh1996/StructureBoxes#18

Allow us to put a timer onto items so they can disappear after X time

Steps to reproduce:

1. Load server with all required plugins on 1.16.3
2. Create new shop
3. Give or create items with &rNAME in order to remove all coloricode
4. Add item to shop
5. Item name is not italicized
6. Restart server, reload server, or reload dtl traders
7. Open shop and observer item

RESULT (10/10):
Item name changes to italicized.

EXPECTED RESULTS:
Item name should remain as initially setup.

Versions:

• dtlTrader (6.2.6)
• PaperMC (paper-251) for 1.16.3

Before restart

After restart

This one is a little difficult to explain.

I have 2 pages, the first page I have 1 item in the centre of the GUI.
On the second page, I have an item in the centre of a GUI.

I changed the first-page permission to something else to "hide" it from other players, so I didn't need to delete the page contents.

But for some reason, when I buy from the second-page item, it's using the details of the first-page item.

I set the user limit to 5x limit for my first page Item which I set the permission on the page.
But no matter what I set the second page Item user limit as, it kept picking up the first page limit.

The only way I found how to solve this was to delete the entire shop, then save it to disk, then load it from disk and reload the plugin, then create a new shop.

When i try to trade 3 compass with 3 Loadstones locations in 3 different trades, the trade completes even if i have another loadstone compass with another location set. The metadata are been ignored.

I can trade as many as i want with other compass locations

In those prints i'm using the same compass to trade 3 different compass

testes:
  title: testes
  command: none
  permission: none
  default-shop: buy
  buy-shop-enabled: true
  sell-shop-enabled: true
  trade-shop-enabled: true
  logging-enabled: true
  close-after-purchase: false
  confirmation-window-enabled: false
  pages:
    page-0:
      size: 54
      page-name: '1'
      page-permission: ''
      trade-items:
        item-1:
          id: 15
          type: trade
          item:
            ==: org.bukkit.inventory.ItemStack
            v: 2586
            type: GRASS_BLOCK
          show-description: true
          description: []
          trade-price: 0.0
          show-obtainable-items: true
          obtainable-items:
            obtainable-item-1:
              item:
                ==: org.bukkit.inventory.ItemStack
                v: 2586
                type: GRASS_BLOCK
          show-needed-items: true
          needed-items:
            trade-item-0:
              item:
                ==: org.bukkit.inventory.ItemStack
                v: 2586
                type: COMPASS
                meta:
                  ==: ItemMeta
                  meta-type: COMPASS
                  LodestonePosWorld: minecraft:azenzo
                  LodestonePosX: 78
                  LodestonePosY: 4
                  LodestonePosZ: -37
                  LodestoneTracked: true
          show-trade-limit: false
          trade-limit: -1
          show-limit-time: false
          limit-reset-seconds: -1
          show-broadcast-message: false
          broadcast-message: ''
          drop-item-on-full-inventory: false
          sell-all-when-not-enough-items: true
          custom-display-text-enabled: false
          custom-display-text: []
          permission: ''
          logging-enabled: true
          close-after-purchase: false
        item-2:
          id: 16
          type: trade
          item:
            ==: org.bukkit.inventory.ItemStack
            v: 2586
            type: GRASS_BLOCK
          show-description: true
          description: []
          trade-price: 0.0
          show-obtainable-items: true
          obtainable-items:
            obtainable-item-11:
              item:
                ==: org.bukkit.inventory.ItemStack
                v: 2586
                type: COMPASS
                meta:
                  ==: ItemMeta
                  meta-type: COMPASS
                  LodestonePosWorld: minecraft:azenzo
                  LodestonePosX: 100
                  LodestonePosY: 4
                  LodestonePosZ: -41
                  LodestoneTracked: true
          show-needed-items: true
          needed-items:
            trade-item-11:
              item:
                ==: org.bukkit.inventory.ItemStack
                v: 2586
                type: GRASS_BLOCK
          show-trade-limit: false
          trade-limit: -1
          show-limit-time: false
          limit-reset-seconds: -1
          show-broadcast-message: false
          broadcast-message: ''
          drop-item-on-full-inventory: false
          sell-all-when-not-enough-items: true
          custom-display-text-enabled: false
          custom-display-text: []
          permission: ''
          logging-enabled: true
          close-after-purchase: false
        item-3:
          id: 17
          type: trade
          item:
            ==: org.bukkit.inventory.ItemStack
            v: 2586
            type: GRASS_BLOCK
          show-description: true
          description: []
          trade-price: 0.0
          show-obtainable-items: true
          obtainable-items:
            obtainable-item-21:
              item:
                ==: org.bukkit.inventory.ItemStack
                v: 2586
                type: GRASS_BLOCK
          show-needed-items: true
          needed-items:
            trade-item-12:
              item:
                ==: org.bukkit.inventory.ItemStack
                v: 2586
                type: COMPASS
                meta:
                  ==: ItemMeta
                  meta-type: COMPASS
                  LodestonePosWorld: minecraft:azenzo
                  LodestonePosX: 87
                  LodestonePosY: 4
                  LodestonePosZ: -34
                  LodestoneTracked: true
          show-trade-limit: false
          trade-limit: -1
          show-limit-time: false
          limit-reset-seconds: -1
          show-broadcast-message: false
          broadcast-message: ''
          drop-item-on-full-inventory: false
          sell-all-when-not-enough-items: true
          custom-display-text-enabled: false
          custom-display-text: []
          permission: ''
          logging-enabled: true
          close-after-purchase: false
        item-20:
          id: 9
          type: trade
          item:
            ==: org.bukkit.inventory.ItemStack
            v: 2586
            type: LODESTONE
          show-description: true
          description: []
          trade-price: 0.0
          show-obtainable-items: true
          obtainable-items:
            obtainable-item-22:
              item:
                ==: org.bukkit.inventory.ItemStack
                v: 2586
                type: ENCHANTED_BOOK
                meta:
                  ==: ItemMeta
                  meta-type: ENCHANTED
                  stored-enchants:
                    BINDING_CURSE: 1
          show-needed-items: true
          needed-items:
            trade-item-21:
              item:
                ==: org.bukkit.inventory.ItemStack
                v: 2586
                type: COMPASS
                meta:
                  ==: ItemMeta
                  meta-type: COMPASS
                  LodestonePosWorld: minecraft:azenzo
                  LodestonePosX: 78
                  LodestonePosY: 4
                  LodestonePosZ: -37
                  LodestoneTracked: true
            trade-item-23:
              item:
                ==: org.bukkit.inventory.ItemStack
                v: 2586
                type: COMPASS
                meta:
                  ==: ItemMeta
                  meta-type: COMPASS
                  LodestonePosWorld: minecraft:azenzo
                  LodestonePosX: 78
                  LodestonePosY: 4
                  LodestonePosZ: -37
                  LodestoneTracked: true
          show-trade-limit: false
          trade-limit: -1
          show-limit-time: false
          limit-reset-seconds: -1
          show-broadcast-message: false
          broadcast-message: ''
          drop-item-on-full-inventory: false
          sell-all-when-not-enough-items: true
          custom-display-text-enabled: false
          custom-display-text: []
          permission: ''
          logging-enabled: true
          close-after-purchase: false
        item-24:
          id: 11
          type: trade
          item:
            ==: org.bukkit.inventory.ItemStack
            v: 2586
            type: ENCHANTED_BOOK
            meta:
              ==: ItemMeta
              meta-type: ENCHANTED
              repair-cost: 1
              stored-enchants:
                PROTECTION_FIRE: 4
          show-description: true
          description: []
          trade-price: 10.0
          show-obtainable-items: true
          obtainable-items:
            obtainable-item-22:
              item:
                ==: org.bukkit.inventory.ItemStack
                v: 2586
                type: BEACON
          show-needed-items: true
          needed-items:
            trade-item-21:
              item:
                ==: org.bukkit.inventory.ItemStack
                v: 2586
                type: ENCHANTED_BOOK
                meta:
                  ==: ItemMeta
                  meta-type: ENCHANTED
                  repair-cost: 1
                  stored-enchants:
                    PROTECTION_FIRE: 4
            trade-item-22:
              item:
                ==: org.bukkit.inventory.ItemStack
                v: 2586
                type: ENCHANTED_BOOK
                meta:
                  ==: ItemMeta
                  meta-type: ENCHANTED
                  repair-cost: 1
                  stored-enchants:
                    PROTECTION_FIRE: 4
          show-trade-limit: false
          trade-limit: -1
          show-limit-time: false
          limit-reset-seconds: -1
          show-broadcast-message: false
          broadcast-message: ''
          drop-item-on-full-inventory: false
          sell-all-when-not-enough-items: true
          custom-display-text-enabled: false
          custom-display-text: []
          permission: ''
          logging-enabled: true
          close-after-purchase: false

Hey Guys,

I have a problem with inventory and item sorting.
Unfortunately, when I bring an item to slot 1 by clicking "1", it doesn't work.
Double-clicking items to add them to the stack doesn't work either.

Sorry for the bad english skills xD

As the title states. "Buy and Keep" command items will run shortly after purchasing without the player using right-click with the item.

Steps to Reproduce:

1. Add a Command Item to a shop and set as "Buy and Keep"
2. Add the command "say %player%" to the item
3. Purchase the item and the command will immediately run (sometimes the item can be briefly seen in the hotbar)

GIFs to demonstrate: https://cdn.discordapp.com/attachments/529708707089612821/761819342915502090/tradersbug1.gif

https://cdn.discordapp.com/attachments/529708707089612821/761831473392910356/tradersbug2.gif

List of Plugins (26): LuckPerms, WorldEdit, PlaceholderAPI, Oh_the_dungeons_youll_go, Multiverse-Core, ProtocolLib, WorldGuard, Multiverse-Portals, Vault, MyCommand, dynmap, Coins, ChestShop, Chunky, Essentials, SinglePlayerSleep, ChunkyBorder, HolographicDisplays, DeadChest, DecoHeads, Citizens, EssentialsChat, SuperVanish, dtlTradersPlus, CrateReloaded, DiscordSRV

Hello,

I know dtltraders doesn't support 1.19.2 fully yet, but apart from problem described below everything works properly.

I can't change items price for sell in npc shop from citizens

[13:29:48 ERROR]: Could not pass event InventoryClickEvent to dtlTraders v6.4.15
java.lang.NoSuchMethodError: 'net.minecraft.world.entity.player.PlayerInventory net.minecraft.server.level.EntityPlayer.fB()'
at net.wesjd.anvilgui.version.Wrapper1_19_R1$AnvilContainer.(Wrapper1_19_R1.java:98) ~[dtlTraders-6.4.15.jar:?]
at net.wesjd.anvilgui.version.Wrapper1_19_R1.newContainerAnvil(Wrapper1_19_R1.java:91) ~[dtlTraders-6.4.15.jar:?]
at net.wesjd.anvilgui.AnvilGUI.openInventory(AnvilGUI.java:176) ~[dtlTraders-6.4.15.jar:?]
at net.wesjd.anvilgui.AnvilGUI.(AnvilGUI.java:164) ~[dtlTraders-6.4.15.jar:?]
at net.wesjd.anvilgui.AnvilGUI.(AnvilGUI.java:30) ~[dtlTraders-6.4.15.jar:?]
at net.wesjd.anvilgui.AnvilGUI$Builder.open(AnvilGUI.java:486) ~[dtlTraders-6.4.15.jar:?]
at com.degitise.minevid.dtlTraders.guis.guiservices.ShopEditService.editItemPrice(ShopEditService.java:3360) ~[dtlTraders-6.4.15.jar:?]
at com.degitise.minevid.dtlTraders.guis.guiservices.ShopEditService.access$5400(ShopEditService.java:34) ~[dtlTraders-6.4.15.jar:?]
at com.degitise.minevid.dtlTraders.guis.guiservices.ShopEditService$19.onClick(ShopEditService.java:2115) ~[dtlTraders-6.4.15.jar:?]
at com.degitise.minevid.dtlTraders.customInventory.DtlCustomInventoryService.onInventoryClickEvent(DtlCustomInventoryService.java:80) ~[dtlTraders-6.4.15.jar:?]
at com.destroystokyo.paper.event.executor.asm.generated.GeneratedEventExecutor1319.execute(Unknown Source) ~[?:?]
at org.bukkit.plugin.EventExecutor.lambda$create$1(EventExecutor.java:75) ~[purpur-api-1.19.2-R0.1-SNAPSHOT.jar:?]
at co.aikar.timings.TimedEventExecutor.execute(TimedEventExecutor.java:76) ~[purpur-api-1.19.2-R0.1-SNAPSHOT.jar:git-Purpur-1755]
at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:70) ~[purpur-api-1.19.2-R0.1-SNAPSHOT.jar:?]
at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:678) ~[purpur-api-1.19.2-R0.1-SNAPSHOT.jar:?]
at net.minecraft.server.network.ServerGamePacketListenerImpl.handleContainerClick(ServerGamePacketListenerImpl.java:3400) ~[?:?]
at net.minecraft.network.protocol.game.ServerboundContainerClickPacket.handle(ServerboundContainerClickPacket.java:58) ~[?:?]
at net.minecraft.network.protocol.game.ServerboundContainerClickPacket.handle(ServerboundContainerClickPacket.java:23) ~[?:?]
at net.minecraft.network.protocol.PacketUtils.lambda$ensureRunningOnSameThread$0(PacketUtils.java:51) ~[?:?]
at net.minecraft.server.TickTask.run(TickTask.java:18) ~[purpur-1.19.2.jar:git-Purpur-1755]
at net.minecraft.util.thread.BlockableEventLoop.doRunTask(BlockableEventLoop.java:153) ~[?:?]
at net.minecraft.util.thread.ReentrantBlockableEventLoop.doRunTask(ReentrantBlockableEventLoop.java:24) ~[?:?]
at net.minecraft.server.MinecraftServer.doRunTask(MinecraftServer.java:1387) ~[purpur-1.19.2.jar:git-Purpur-1755]
at net.minecraft.server.MinecraftServer.d(MinecraftServer.java:185) ~[purpur-1.19.2.jar:git-Purpur-1755]
at net.minecraft.util.thread.BlockableEventLoop.pollTask(BlockableEventLoop.java:126) ~[?:?]
at net.minecraft.server.MinecraftServer.pollTaskInternal(MinecraftServer.java:1364) ~[purpur-1.19.2.jar:git-Purpur-1755]
at net.minecraft.server.MinecraftServer.pollTask(MinecraftServer.java:1357) ~[purpur-1.19.2.jar:git-Purpur-1755]
at net.minecraft.util.thread.BlockableEventLoop.runAllTasks(BlockableEventLoop.java:114) ~[?:?]
at net.minecraft.server.MinecraftServer.tickServer(MinecraftServer.java:1491) ~[purpur-1.19.2.jar:git-Purpur-1755]
at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1213) ~[purpur-1.19.2.jar:git-Purpur-1755]
at net.minecraft.server.MinecraftServer.lambda$spin$1(MinecraftServer.java:310) ~[purpur-1.19.2.jar:git-Purpur-1755]
at java.lang.Thread.run(Thread.java:833) ~[?:?]

Greetings

when some one has 6000 money he can buy everything without decreasing the balance

hi , i try to add a command with 20+ caractere he deleted the end of the command , i don't know if it's an issues on my side or if it's due to the format to enter a command with then envil syteme ? thanks for ur help

Good afternoon!

I found a bug on my server. If you hover the cursor over an item in the store, and then click a combination like 3+e, where 3 is a slot from the hotbar, and e is the closure of the inventory, then the item gets into the selected hotbar cell for free and the store closes.

PaperMC: 1.16.5#768
dtlTraders-plus: 6.4.1

Global Limits for items, so set 50 items for sale, that's the total that can be sold to all players.