mineralscloud / abinitiosoftwarebase.jl Goto Github PK

@JuliaRegistrator register

In this commit I removed all Setters because they are hard to join together. But now if I make them all structs, and the parameters I want to set as fields, they I can make them functors & take template as the sole argument of that functor. Then I can join them because they are only 1 argument functions. You cannot join multiple multi-arg functions.

@JuliaRegistrator register branch=yaml

@JuliaRegistrator register

@JuliaRegistrator register branch=getpotentials

In the last commit I move readoutput from Express.EosFitting to here, with some change of arguments. That is, move the calc into the inner layer of the closures, and thus the outer layer which takes the actual file, etc., can be extended. This is already a generalization. But can more be done?

Maybe I can just change the default parser from nothing to identity so that I don't have the check against isnothing and I can put parser as the first argument so we can make use of a do block, just like open. What about it?

@JuliaRegistrator register

This issue is used to trigger TagBot; feel free to unsubscribe.

If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.

If you'd like for me to do this for you, comment TagBot fix on this issue.
I'll open a PR within a few hours, please be patient!

@JuliaRegistrator register

@JuliaRegistrator register