mindstand / go-bolt Goto Github PK

When a query fails it says it failed to ack failure and doesn't actually say what the error was. The actual error can usually be found in decode that made the ack failure necessary. So the best thing to do would be to extract the actual error and not return or wrap the ack failure.

The error that gets returned looks like this

An error occurred decoding ack failure message response\n\tCouldn't read expected bytes for message length. Read: 0 Expected: 2.\nInternal Error(*errors.errorString):EOF

when the actual error (extracted from logs) is

Acknowledging Failure: messages.FailureMessage{Metadata:map[string]interface {}{"code":"Neo.ClientError.Statement.SyntaxError", "message":"Variable `m` not defined (line 1, column 370 (offset: 369))\n\"{query_redacted}"\n

With multidb in V4, I originally thought the leader node was consistent for all databases so it was designed for consistent write and reads. The pooling logic now needs to be changed depending on the database.

Consider the typed string type mySpecialString string. The current encoder will not recognize any variables of this type as a string and will fail to encode it.

Should i open connection for each query?

Add support for bookmarks. Reference here and here