The avro-netty from milenkovicm

avro-netty's People

Contributors

Stargazers

Watchers

avro-netty's Issues

Is necessary to handle TCP packet splicing in AvroDecoder?

Hi, I have a question about the demo decoder in README.

    @Override
    protected void decode(ChannelHandlerContext ctx, ByteBuf in, List<Object> out) throws Exception {
        //Do we need to handle TCP splicing here before DatumReader read?
        final NettyByteBufDecoder decoder = new NettyByteBufDecoder(in);
        final DatumReader<GenericRecord> reader = new GenericDatumReader<>(schema);
        try {
            final GenericRecord record = reader.read(null, decoder);
            out.add(record);
        } catch (final IOException e) {
            throw new RuntimeException(e);
        }
    }

decoder throws IndexOutofBoundsException

from readInt and readString in ByteBufDecoder

when reading from ByteBuf to decoder

I found the exception throws from here:

Netty 4.0.33 io.netty.buffer.AbstractByteBuf.java line 1178

private void checkReadableBytes0(int minimumReadableBytes) {
        ensureAccessible();
        if (readerIndex > writerIndex - minimumReadableBytes) {
            throw new IndexOutOfBoundsException(String.format(
                    "readerIndex(%d) + length(%d) exceeds writerIndex(%d): %s",
                    readerIndex, minimumReadableBytes, writerIndex, this));
        }
}

Caused by: java.lang.IndexOutOfBoundsException
	at io.netty.buffer.EmptyByteBuf.readUnsignedByte(EmptyByteBuf.java:445)
	at com.github.milenkovicm.avro.io.ByteBufDecoder.readInt(ByteBufDecoder.java:38)
	at com.github.milenkovicm.avro.io.ByteBufDecoder.readString(ByteBufDecoder.java:91)
	at org.apache.avro.io.ResolvingDecoder.readString(ResolvingDecoder.java:201)
	at org.apache.avro.generic.GenericDatumReader.readString(GenericDatumReader.java:430)
	at org.apache.avro.generic.GenericDatumReader.readString(GenericDatumReader.java:422)

avro schema:

{"namespace": "example.avro",
 "type": "record",
 "name": "User",
 "fields": [
     {"name": "name", "type": "string"},
     {"name": "favorite_number",  "type": ["int", "null"]},
     {"name": "favorite_color", "type": ["string", "null"]}
 ]
}

Recommend Projects