The spatial from mikemalinowski

spatial's People

Contributors

spatial's Issues

Non-intersecting bounds intersect

When checking intersection of bounds, the method intersect returns a false positive if the bounds intersect in one dimension but lay completely outside of each other considering all dimensions (red region). It works correctly if all they lay outside in all dimensions (green):

Example:

Bounds([(0,0), (1,1)]).intersects(Bounds([(-2,0), (-1,1)]))

    def intersects(self, bounds):
        """
        Tests whether this bounding box and the given bounding box
        intersect one-another.
        :param bounds: spatial.Bounds
        :return: bool 
        """
        if bounds.num_dimensions() > self.num_dimensions():
            return False

        intersects_in_dimension = [False] * self.num_dimensions()

        # Check whether at least one corner of bounds is within self.
        for dimension in range(bounds.num_dimensions()):
            if bounds.min(dimension) >= self.min(dimension) and bounds.min(
                    dimension) <= self.max(dimension):
                intersects_in_dimension[dimension] = True
                continue

            if bounds.max(dimension) >= self.min(dimension) and bounds.max(
                    dimension) <= self.max(dimension):
                intersects_in_dimension[dimension] = True
                continue

        if all(intersects_in_dimension):
            return True

        # Otherwise bounds could be fully containing self (all corners outside).
        # Check whether any arbitrary corner of self is within bounds.
        for dimension in range(bounds.num_dimensions()):
            if self.min(dimension) >= bounds.min(dimension) and self.min(
                    dimension) <= bounds.max(dimension):
                intersects_in_dimension[dimension] = True

        return all(intersects_in_dimension)

Recommend Projects