mikemalinowski / factories Goto Github PK
View Code? Open in Web Editor NEWFactory/Plugin Pattern Implementation
License: MIT License
Factory/Plugin Pattern Implementation
License: MIT License
factories/factories/factory.py
Line 868 in c353032
Currently doing a truthy check on version instead of explicit version is None
.
The current implementation will mean any plugins with valid <1 version values will never be accessible.
It also removes the possibility of retroactively inserting legacy versions of plugins.
factories/factories/factory.py
Line 121 in c353032
Potential security issue using exec on filename.
Unlikely severe due to file character restrictions but worth investigating for viable parsing/checks before executing.
factories/factories/factory.py
Line 716 in c353032
Comparing to the abstract class will completely depend on the comparison implementation of the left handed object.
This could lead to false positives.
The upside to such implementation may make dynamic reloading easier, but IMO this is not something that should be handled via equality testing.
factories/factories/factory.py
Line 325 in c353032
BaseException should not be used to generally catch all exceptions as it will catch things like StopIteration etc.
If you need to catch any exception type NOT subclassed from Exception, then it's much clearer to do it in an additional except block.
factories/factories/factory.py
Line 673 in c353032
factories/factories/factory.py
Line 321 in c353032
When dynamically importing files, we check for the first directory that doesn't have an init.py.
Perhaps we should check until the root and then warn that there may be issues if the loaded plugin isn't a direct descendant of a root package.
Think import common
.
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.