Giter Club home page Giter Club logo

Comments (7)

franktcurran avatar franktcurran commented on July 28, 2024

I gave it a shot locally, but have been hung up on getting the sticky footer example to work.
What I have working has the following usage:

{{#materialize-footer}}
  <div class="container">
    <div class="row">
      <div class="col l6 s12">
        <h5 class="white-text">Footer Content</h5>
        <p class="grey-text text-lighten-4">You can use rows and columns here to organize your footer content.</p>
      </div>
      <div class="col l4 offset-l2 s12">
        <h5 class="white-text">Links</h5>
        <ul>
          <li><a class="grey-text text-lighten-3" href="#!">Link 1</a></li>
          <li><a class="grey-text text-lighten-3" href="#!">Link 2</a></li>
          <li><a class="grey-text text-lighten-3" href="#!">Link 3</a></li>
          <li><a class="grey-text text-lighten-3" href="#!">Link 4</a></li>
        </ul>
      </div>
    </div>
  </div>
  {{#materialize-copyright text='Copyright Text'}}<a class="grey-text text-lighten-4 right" href="#!">More Links</a>{{/materialize-copyright}}
{{/materialize-footer}}

from ember-cli-materialize.

mike-north avatar mike-north commented on July 28, 2024

if we can, I'd like to avoid the container/row being included in the body of the footer, in the interest of taking care of as much "no brainer" stuff as possible for users

from ember-cli-materialize.

rynam0 avatar rynam0 commented on July 28, 2024

I'm kind of fond of the fact that in the second example the copyright element is a component as well. This makes it possible for me to extend/override its capabilities quite easily. It also allows me to add content to it if I wish or simply leave it out since it appears to support that as well. I like no-brainers for sure but i'm wondering what subFooterView is... Do I need to supply a view class/template for my footer if I don't want the default? How do I extend it if it is not exposed as a component too?
By setting it to null, does this mean I can simply omit that attribute or does that mean i actually have to pass null as the attribute value?

from ember-cli-materialize.

sgasser avatar sgasser commented on July 28, 2024

But make this component sense?
As user I save here only 4 lines of code and the footer is not a component used more than one time.

This

{{#materialize-footer subfooterView="myFooterViewClass"}}
...
{{/materialize-footer}}

instead of this

<footer class="page-footer">
  <div class="container">
    <div class="row">
...
    </div>
  </div>
</footer>

from ember-cli-materialize.

rynam0 avatar rynam0 commented on July 28, 2024

I think it could make sense due to the fact that the copyright is being provided with logic to use the current year. Consuming apps wouldn't have to do this themselves.

from ember-cli-materialize.

mike-north avatar mike-north commented on July 28, 2024

@sgasser I agree that the less work we save the developer, the less components like these make sense. Particularly if the decision is to go the route that @franktcurran has proposed, we probably don't need to build this at all (I think it would mean 0 lines saved).

The existing content projection capability of {{yield}} doesn't really let us have our cake and eat it too. I think the best we can shoot for without hacking around in the view rendering code is saving the user from having to deal with the particulars of the grid/container stuff.

from ember-cli-materialize.

franktcurran avatar franktcurran commented on July 28, 2024

@truenorth, @sgasser - It looks like we have this settled in #53. No footer component for now. Can we close this or am I wrong? Thanks!

from ember-cli-materialize.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.