TypeError when closing a Modal about ember-cli-materialize HOT 4 OPEN

@mike-north why not accept PR ?

from ember-cli-materialize.

@mike-north why not accept PR ?

I suspect that he has not had time or interest to continue maintaining this project (I know that that happens to me quite a bit -- it's often more involved than simply accepting a PR: review, CI tweaks, changelog, publishing, ...). There's quite a bit of effort that would be needed to bring this addon up to the latest Ember conventions, etc. There has also been very little visible activity on Materialize (see Dogfalo/materialize#6438 (comment)), which may also be contributing.

from ember-cli-materialize.

@mike-north why not accept PR ?

I suspect that he has not had time or interest to continue maintaining this project (I know that that happens to me quite a bit -- it's often more involved than simply accepting a PR: review, CI tweaks, changelog, publishing, ...). There's quite a bit of effort that would be needed to bring this addon up to the latest Ember conventions, etc. There has also been very little visible activity on Materialize (see Dogfalo/materialize#6438 (comment)), which may also be contributing.

He had a year to review the PR, so I can assume that this project is abandoned, true ?

from ember-cli-materialize.

@vladern the project needs a lot of work to be maintained. I don't know if the developer is going to take a look to all PRs. The best way to go is to create a fork of the project. I made a lot of improvements (never merged into master) and I have a lot of knowledge of the repo, let me know if you need help with that 😄 .

from ember-cli-materialize.