mik629 / androidfundamentalsapp Goto Github PK

Ruslan's comment

Improve test coverage, as per Ruslan's comment

Ruslan's coment.
Looks like a bad idea to load movie details for all movies in the list at once, better to load discretely.
And MovieDetails should contain Movie data (comment)

Either use a better implementation of RatingBar which allows usage of svg or implement a new one

Ruslan's comment

rHlushan 16 days ago

think about recycler view

same ViewHolder is reused(view is reused)
first item has rating 0
second item has rating 5
after first item bind : all stars are GRAY
after second item bind: all stars still are GRAY

Ruslan's comment

• use cicerone or navigation component for navigation between screens

• use toolbar instead of TextView for list title or make this title a part of list so that it would scroll up together with movie cards

Ruslan's comment and another comment