mightydevices / stbootlib Goto Github PK

Hi Tomasz,
I have probably found some small bugs in your code. I hope that you will check it and maybe it will helps to you to improve your code. Please feel free to tell me if I'm wrong.
Best regards,
Martin Mostek
Ps: Thank You very much for your bootloader code, it helps me in my understanding of the STM Bootloader.

Bugs report:
In ExtendedErase function is wrong check sum :
/* checksum /
tx[6] = (byte)~ComputeChecksum(tx, 2, 5);
it should be:
/ checksum */
tx[6] = (byte)~ComputeChecksum(tx, 2, 4);

next (the same bug):
in EraseSpecial function is wrong check sum :
/* checksum /
tx[3] = (byte)~ComputeChecksum(tx, 2, 2);
it should be:
/ checksum */
tx[3] = (byte)~ComputeChecksum(tx, 2, 1);

and finally:
in ExtendedEraseSpecial function is wrong check sum :
/* checksum /
tx[4] = (byte)~ComputeChecksum(tx, 2, 3);
it should be:
/ checksum */
tx[4] = (byte)~ComputeChecksum(tx, 2, 2);

What license is this released under? If you have no preference, I'd recommend the Apache License v2.0 or the MIT license.