Safari UI is broken on iPhone

I'm in the second video from the kings league project. I followed every step to add presidents data to leaderboard. But it show me this error: TypeError: Cannot destructure property 'presidentId' of 'TEAMS.find(...)' as it is undefined.

index.js from api folder

` import { writeFile, readFile } from 'node:fs/promises'
import path from 'node:path'

const DB_PATH = path.join(process.cwd(), './db/')

function readDBFile (dbName) {
return readFile(${DB_PATH}/${dbName}.json, 'utf-8').then(JSON.parse)
}

export const TEAMS = await readDBFile('teams')
export const PRESIDENTS = await readDBFile('presidents')
export function writeDBFile (dbName, data) {
writeFile(${DB_PATH}/${dbName}.json, JSON.stringify(data, null, 2), 'utf-8')
} `

leaderboard.js
`
import * as cheerio from 'cheerio'
import { TEAMS, PRESIDENTS, writeDBFile } from '../db/index.js'

const URLS = {
leaderboard: 'https://kingsleague.pro/estadisticas/clasificacion/'
}

async function scrape (url) {
const res = await fetch(url)
const html = await res.text()
return cheerio.load(html)
}

async function getLeaderBoard () {
const $ = await scrape(URLS.leaderboard)
const $rows = $('table tbody tr')

const getTeamFrom = ({ name }) => {
const { presidentId, ...restOfTeam } = TEAMS.find(team => team.name === name)
const president = PRESIDENTS.find(president => president.id === presidentId)
return { ...restOfTeam, president }
}

const cleanText = text => text
.replace(/\t|\n|\s:/g, '')
.replace(/.*:/g, ' ')
.trim()

const LEADERBOARD_SELECTORS = {
team: { selector: '.fs-table-text_3', typeOf: 'string' },
wins: { selector: '.fs-table-text_4', typeOf: 'number' },
loses: { selector: '.fs-table-text_5', typeOf: 'number' },
goalsScored: { selector: '.fs-table-text_6', typeOf: 'number' },
goalsConceded: { selector: '.fs-table-text_7', typeOf: 'number' },
cardsYellow: { selector: '.fs-table-text_8', typeOf: 'number' },
cardsRed: { selector: '.fs-table-text_9', typeOf: 'number' }
}

const leaderboardSelectorEntries = Object.entries(LEADERBOARD_SELECTORS)

const leaderboard = []

$rows.each((index, el) => {
const leaderBoardEntries = leaderboardSelectorEntries.map(([key, { selector, typeOf }]) => {
const rawValue = $(el).find(selector).text()
const cleanedValue = cleanText(rawValue)
const value = typeOf === 'number' ? Number(cleanedValue) : cleanedValue
return [key, value]
})

const { team: teamName, ...leaderboardForTeam } = Object.fromEntries(leaderBoardEntries)

const team = getTeamFrom({ name: teamName })

leaderboardForTeam.teamId = getTeamFrom(leaderboardForTeam)

leaderboard.push({
  ...leaderboardForTeam,
  team
})

})

return leaderboard
}

const leaderboard = await getLeaderBoard()

await writeDBFile('leaderboard', leaderboard)

`

En la linea 34 sale el error que dice kings-league-project\src\pages\index.astro:34:11

Vínculos incorrectos del nombre corto en la tarjeta de las jornadas:

JFC Cambiar de https://kingsleague.dev/team/jijantes a https://kingsleague.dev/team/jijantes-fc/
PIO Cambia de https://kingsleague.dev/team/pio a https://kingsleague.dev/team/pio-fc/
TFC Cambiar de https://kingsleague.dev/team/los-troncos a https://kingsleague.dev/team/los-troncos-fc/

When the Scrape action is executed this does not trigger the action to deploy the API in Cloudflare.

We Can find more information to solve that here:
https://docs.github.com/es/actions/using-workflows/triggering-a-workflow#triggering-a-workflow-from-a-workflow

On devices with a resolution of 1440 wide, the match hour can partially hide the team name.

The new design of the header looks really nice 🎉, but the logos of the Los Troncos FC and Kunisports don't have good contrast with the background 😔.

The top_scorer.js scrapper doesn't delete the selector ranking and creates a duplicate key in the final object like this.

    {
      "ranking": 1
      "playerName": "R. Carbó",
      "gamesPlayed": 1,
      "goals": 3,
      "rank": 1,
      "team": "Saiyans FC",
      "image": "https://kings-league-api.bjvalmaseda.workers.dev/static/logos/saiyans-fc.svg"
    },

This object must have only a rank or ranking key eg.

    {
      "ranking": 1,
      "playerName": "R. Carbó",
      "gamesPlayed": 1,
      "goals": 3,
      "team": "Saiyans FC",
      "image": "https://kings-league-api.bjvalmaseda.workers.dev/static/logos/saiyans-fc.svg"
    },

Home

Calendario

Contacto

Equipo

I was trying to figure out what was happening with the issue: #240 and I realized that some scrappers are not working. I don't know if that only happen to me

Jijantes-fc link is broken on the schedules tables:

Home page:

/Calendario page:

Probably the reason is the mapping done in the schedule scraper, but the problem is that the logo is named 'jijantes.svg', so, if we change the team name to 'jijantes-fc', the image will broke.

Overview

List of refactors or improvements that can be done to scraping folder.

List

• Create a function for this piece of code

const rawValue = $el.find(selector).text()
const cleanedValue = cleanText(rawValue)
const value = typeOf === 'number' ? Number(cleanedValue) : cleanedValue

Something like getValueFromElement($, selector, typeOf)

• Export getImageFromTeam from mvp.js to a util file and use it in scrappers

Others improvements are welcomed.

Actualmente, nuestros tests se encuentran mezclados con el resto del código fuente en la carpeta raíz del proyecto. Esto puede hacer difícil de rápidamente identificar qué archivos son tests y cuáles no. Además, algunas convenciones de estructuración de proyectos suelen sugerir tener una carpeta específica para los tests.

Por lo tanto, propongo crear una carpeta llamada 'test' y mover todos los archivos de test dentro de ella. Esto debería hacer más fácil mantener una vista general de los tests y seguir las buenas prácticas de estructuración de proyectos.

Por favor, asignen este issue a alguien para que pueda ser abordado.

[![Deploy API](https://github.com/midudev/kings-league-project/actions/workflows/deploy-api.yml/badge.svg?branch=main)](https://github.com/maikCyphlock/kings-league-project/actions/workflows/deploy-api.yml) [![Scrape Kings League Infojobs Website](https://github.com/midudev/kings-league-project/actions/workflows/scrape-kings-league-web.yml/badge.svg?branch=main)](https://github.com/maikCyphlock/kings-league-project/actions/workflows/scrape-kings-league-web.yml)

Hover a tiktok icon turns it completely white.

in devtools when push mobil button to see the web how it shows up then it happens this 👇

Some of the images do not load well, and as I saw in the 6h live, a solution had been put to the alignment of the names in the table.

Reproducing the problem

If we go inside the team profile route:
https://kingsleague.dev/team/pio-fc/

We can see that the image of B. Juarez is not displaying correctly

And if we call the API with the players name:

https://api.kingsleague.dev/static/players/pio-fc-b-ju%C3%A1rez.png

We get a JSON response saying:

{"message":"Not Found"}

Details

Doing a normal refresh or CTRL+SHIFT+R refresh to ensure that the cache is clean does not bring the image neither.

If more information is needed or my contribution is lacking in some way, im happy to revisit this issue.
Thank you!

mobile

tablet

laptop <1500 resolution

Teams logos are stacked in front of the mobile menu:

Before:

After:

Buenos dias,

He encontrado un pequeñito fallito, y como una imagen vale más que mil palabras, la pongo a continuación:

Como se puede ver en la imagen, para ciertos tamaños de pantalla el menú de navegación de la página de estadísticas es tapado por la imagen del jugador, en este caso la del mvp.

Me pongo a ver si lo puedo arreglar 🚀

Un saludo, muchas gracias

The reason is the /teams prefix. You can check this reading the astro console warnings:

We can use the Google Favicon endpoint to get the favicons of the social media links instead of using ifs or a switch per domain.

https://www.google.com/s2/favicons?domain=${domain}&sz=32