microud / nest-mqtt Goto Github PK

View Code? Open in Web Editor NEW

44.0 44.0 33.0 45 KB

A MQTT module for Nest.js.

License: MIT License

TypeScript 100.00%

nest-mqtt's People

Contributors

Stargazers

Watchers

nest-mqtt's Issues

MQTT connection is not closing properly on application shutdown

When a NestJS application using this MQTT module is shut down, the MQTT connection created is not properly closed bi calling the end method.

This may keep the application running even after Jest's integration or E2e tests have already finished.

Tried to publish a string but received an error

Hi there, would like to ask why would I get this error when I try to publish a string? Here attached are the errors stated in command prompt:

SyntaxError: Unexpected token è in JSON at position 0
at JSON.parse ()
at exports.JsonTransform (C:\Users\user\test-nestjs\node_modules\nest-mqtt\dist\mqtt.transform.js:4:17)
at C:\Users\user\test-nestjs\node_modules\nest-mqtt\dist\mqtt.explorer.js:108:36
at Array.map ()
at MqttClient. (C:\Users\user\test-nestjs\node_modules\nest-mqtt\dist\mqtt.explorer.js:105:82)
at MqttClient.emit (events.js:311:20)
at MqttClient._handlePublish (C:\Users\user\test-nestjs\node_modules\nest-mqtt\node_modules\mqtt\lib\client.js:1162:12)
at MqttClient._handlePacket (C:\Users\user\test-nestjs\node_modules\nest-mqtt\node_modules\mqtt\lib\client.js:351:12)
at work (C:\Users\user\test-nestjs\node_modules\nest-mqtt\node_modules\mqtt\lib\client.js:283:12)
at Writable.writable._write (C:\Users\user\test-nestjs\node_modules\nest-mqtt\node_modules\mqtt\lib\client.js:294:5)

Please update MQTT to the latest version 4.3.5

You are using an old MQTT version @microud

Nest cannot export a provider/module that is not a part of the currently processed module (MqttModule). Please verify whether the exported MqttService is available in this particular context.

Here's my code:

// app.module.ts

//my imports...
import { MqttModule } from 'nest-mqtt';

@Module({
  imports: [
// All my other modules
    MqttModule,
  ],
})

And I got these errors:

3:38:38 pm - Starting compilation in watch mode...
[1]
[0] [nodemon] 2.0.4
[0] [nodemon] to restart at any time, enter `rs`
[0] [nodemon] watching path(s): dist\**\*       
[0] [nodemon] watching extensions: js
[0] [nodemon] starting `node dist/main`
[0] [Nest] 21736   - 04/10/2021, 3:38:43 pm   [NestFactory] Starting Nest application...
[0] [Nest] 21736   - 04/10/2021, 3:38:44 pm   [ExceptionHandler] Nest cannot export a provider/module that is not a part of the currently processed module (MqttModule). Please verify whether the exported MqttService is available in this particular context.
[0]
[0] Possible Solutions:
[0] - Is MqttService part of the relevant providers/imports within MqttModule?
[0]  +65ms
[0] Error: Nest cannot export a provider/module that is not a part of the currently processed module (MqttModule). Please verify whether the exported MqttService is available in this particular context.
[0]
[0] Possible Solutions:
[0] - Is MqttService part of the relevant providers/imports within MqttModule?
[0]
[0]     at Module.validateExportedProvider (C:\Users\User\Projects\MyProject\node_modules\@nestjs\core\injector\module.js:272:19)
[0]     at addExportedUnit (C:\Users\User\Projects\MyProject\node_modules\@nestjs\core\injector\module.js:239:67)
[0]     at Module.addExportedProvider (C:\Users\User\Projects\MyProject\node_modules\@nestjs\core\injector\module.js:250:9)
[0]     at NestContainer.addExportedProvider (C:\Users\User\Projects\MyProject\node_modules\@nestjs\core\injector\container.js:122:19)
[0]     at DependenciesScanner.insertExportedProvider (C:\Users\User\Projects\MyProject\node_modules\@nestjs\core\scanner.js:209:24)
[0]     at C:\Users\User\Projects\MyProject\node_modules\@nestjs\core\scanner.js:117:50
[0]     at Array.forEach (<anonymous>)
[0]     at DependenciesScanner.reflectExports (C:\Users\User\Projects\MyProject\node_modules\@nestjs\core\scanner.js:117:17)
[0]     at DependenciesScanner.scanModulesForDependencies (C:\Users\User\Projects\MyProject\node_modules\@nestjs\core\scanner.js:69:18)
[0]     at processTicksAndRejections (internal/process/task_queues.js:95:5)
[0] [nodemon] app crashed - waiting for file changes before starting...

`nest-mqtt` does not work over websockets

Is it possible to connect to MQTT broker running over websockets? It seems like it cannot detect such a broker.

I created a broker as follows.

const aedes = require('aedes')()
const {createServer} = require('aedes-server-factory')
const server = createServer(aedes, {ws: true})
const port = 1883
server.listen(port, () => {
  console.log('Server started and listening on port ' + port + '.')
})

Multiple `MqttModule.forRoot()` global instances

In my use case, I need two global MQTT clients: one using MQTT protocol, the other using websockets.

I added the following into app.module.ts:

@Module({
  imports: [
    MqttModule.forRoot({
      port: 1883,
      logger: {
        useValue: new Logger('MqttClient')
      }
    }),
    MqttModule.forRoot({
      protocol: 'ws',
      port: 4000,
      logger: {
        useValue: new Logger('MqttClientWs')
      }
    })
  ],
})

Now, in the service (@Inject(MqttService) private readonly mqttService: MqttService), how can I differentiate between them?

Tried to publish but returned TypeError: this.mqttService.publish is not a function

  constructor(
    @Inject(MqttService) private readonly mqttService: MqttService,
  ) {}

  @Subscribe('/iot/test/#')
  test(@Payload() payload) {
    console.log(payload)
    try {
      this.mqttService.publish("/test", {a: 1}, { qos: 0 })
    } catch (err) {
      console.error(err)
    }
  }

return this

TypeError: this.mqttService.publish is not a function
    at TestService.test (/Volumes/SSD/Development/nestjs/lege-iot-nest/dist/mqtt/service/TestService.js:25:30)
    at MqttClient.<anonymous> (/Volumes/SSD/Development/nestjs/lege-iot-nest/node_modules/[email protected]@nest-mqtt/dist/mqtt.explorer.js:120:64)
    at MqttClient.emit (events.js:315:20)
    at MqttClient._handlePublish (/Volumes/SSD/Development/nestjs/lege-iot-nest/node_modules/[email protected]@mqtt/lib/client.js:1271:12)
    at MqttClient._handlePacket (/Volumes/SSD/Development/nestjs/lege-iot-nest/node_modules/[email protected]@mqtt/lib/client.js:410:12)
    at work (/Volumes/SSD/Development/nestjs/lege-iot-nest/node_modules/[email protected]@mqtt/lib/client.js:321:12)
    at Writable.writable._write (/Volumes/SSD/Development/nestjs/lege-iot-nest/node_modules/[email protected]@mqtt/lib/client.js:335:5)
    at doWrite (/Volumes/SSD/Development/nestjs/lege-iot-nest/node_modules/[email protected]@readable-stream/lib/_stream_writable.js:428:64)
    at writeOrBuffer (/Volumes/SSD/Development/nestjs/lege-iot-nest/node_modules/[email protected]@readable-stream/lib/_stream_writable.js:417:5)
    at Writable.write (/Volumes/SSD/Development/nestjs/lege-iot-nest/node_modules/[email protected]@readable-stream/lib/_stream_writable.js:334:11)
    at Socket.ondata (_stream_readable.js:707:22)
    at Socket.emit (events.js:315:20)
    at addChunk (_stream_readable.js:296:12)
    at readableAddChunk (_stream_readable.js:272:9)
    at Socket.Readable.push (_stream_readable.js:213:10)
    at TCP.onStreamRead (internal/stream_base_commons.js:186:23)

Doesn’t subscribe to topic after reconnect

Issue when publishing binary buffer or Uint8Array

When trying to publish a proto binary buffer the object is converted to JSON string, but it should be published as it is since the client supports buffer / Uint8Array

One way to do it is to change the condition as follow:

  if (typeof message === 'object' && !Buffer.isBuffer(message)) {
    message = JSON.stringify(message);
  }

Is it possible to apply this change ?
Thanks
Andrea

Code from mqtt.service.ts :

  publish(topic: string, message: string | Buffer | object, opts?: IClientPublishOptions): Promise<Packet> {
    return new Promise<Packet>((resolve, reject) => {
      if (typeof message === 'object') {
        message = JSON.stringify(message);
      }
      this.client.publish(topic, message, opts || null, (error, packet) => {
        if (error) {
          reject(error);
        } else {
          resolve(packet);
        }
      });
    });
  }

Is latest version `0.1.5` or `0.1.6`?

In package.json, you have 0.1.5, but on NPM it says 0.1.6.

I suspect that you are not updating the version in package.json and package-lock.json in master after you release a new NPM version.

publish method don't need stringify message

publish method don't need stringify message.

mqtt loop connect and disconnect while backend lost connection because of the same clientId

I'm getting the issue about reconnect while lost connection because of the same cilentId. Are there any options to set new clientId when reconnect?

issue in nestjs 8

can't use in newest version

ERROR [ExceptionHandler] Nest can't resolve dependencies of the MqttExplorer (DiscoveryService, MetadataScanner, MQTT_LOGGER_PROVIDER, ?, MQTT_CLIENT_INSTANCE, MQTT_OPTION_PROVIDER). Please make sure that the argument Reflector at index [3] is available in the MqttModule context.

Potential solutions:

If Reflector is a provider, is it part of the current MqttModule?
If Reflector is exported from a separate @module, is that module imported within MqttModule?
@module({
imports: [ /* the Module containing Reflector */ ]
})

multiple mqtt clients using forRootAsync

Hi there!

In my project I am using more than one mqtt clients, each client is created by one specific module. It works fine when I'm using forRoot method.

However, when I switched to forRootAsync method, only the first module worked, other clients did not init. I tried to load the modules dynamically, but I got the same result. Where could be wrong?

In my app.module.ts:

@Module({
  imports: [
    ConfigModule.forRoot({
      isGlobal: true,
      expandVariables: true,
    }),
    Module1,
    Module2,
    Module3,
    Module4
  ]
})

Only Module1 worked.

microud / nest-mqtt Goto Github PK

nest-mqtt's People

Contributors

Stargazers

Watchers

Forkers

nest-mqtt's Issues

return this

Recommend Projects

Recommend Topics

Recommend Org