The parser validates this file successfully https://devicemodels.azure.com/dtmi/nexcom/nise51/xcare-1.json

but this extension shows:

👋 Hi there, Martin here, from the VS Code team.

Recently we've announced the Remote Repository feature that lets you browse and edit files and folders directly on GitHub.

Open Remote Repository... opens VSCode on a folder or workspace located on a virtual file system. We call this a virtual workspace. We observed that not all extension support this well, either because they can not, or they haven't thought about it.

It would be fantastic if you could test whether your extension can handle virtual workspaces:

Check out the Virtual Workspaces Extension Author Guide on how to do that.

When done, set the new virtualWorkspaces capability in your 'package.json'.

{
  "capabilities": {
    "virtualWorkspaces": true | false
  }
}

• Use "virtualWorkspaces": true if your extension is prepared for virtual workspaces
• Use "virtualWorkspaces": false if your extension should be disabled when a virtual workspace is opened

For questions and comments please use the Virtual Workspaces Tracking Issue.

Thanks for the support and the great work! ❤️

With DTDL v3 semantic types are allowed on Fields, as shown in the example from https://github.com/Azure/opendigitaltwins-dtdl/blob/master/DTDL/v3/DTDL.quantitativeTypes.v1.md

However this VSCode extension shows the next error for the interface below:

This Semantic Type can only be co-typed with type: Property, Telemetry

{
    "@context": [
        "dtmi:dtdl:context;3",
        "dtmi:dtdl:extension:quantitativeTypes;1"
    ],
    "@id": "dtmi:com:example:Sensor;1",
    "@type": "Interface",
    "contents": [
      {
        "@type": "Telemetry",
        "name": "multimeter",
        "schema": {
          "@type": "Object",
          "fields": [
            {
              "@type": [ "Field", "Temperature" ],
              "name": "thermometer",
              "schema": "double",
              "unit": "degreeCelsius"
            },
            {
              "@type": [ "Field", "Pressure" ],
              "name": "barometer",
              "schema": "double",
              "unit": "millibar"
            },
            {
              "@type": [ "Field", "RelativeHumidity" ],
              "name": "humidityMeter",
              "schema": "integer",
              "unit": "percent"
            },
            {
              "@type": [ "Field", "Velocity" ],
              "name": "anemometer",
              "schema": "double",
              "unit": "metrePerSecond"
            }
          ]
        }
      }
    ]
  }

There are important files that Microsoft projects should all have that are not present in this repository. A pull request has been opened to add the missing file(s). When the pr is merged this issue will be closed automatically.

Microsoft teams can learn more about this effort and share feedback within the open source guidance available internally.

Merge this pull request

The next valid DTDL is shown with errors

{
  "@context": "dtmi:dtdl:context;2",
  "@id": "dtmi:com:example:test;1",
  "@type": ["Interface", "NamedInterface"]
}

The following DTDL document produces two errors in the VSCode extension, although it's accepted by the parser

{
  "@context": "dtmi:dtdl:context;2",
  "@id": "dtmi:com:example:myThing;2",
  "@type": "Interface",
  "displayName": "myThing",
  "contents": [
    {
      "@id": "dtmi:com:example:myThing:temperature;1",
      "@type": "Telemetry",
      "name": "temperature",
      "dtmi:dtdl:property:schema;2": "double"
    }
  ]
}

Problems reported

[{
	"resource": "/C:/code/temp/scratch-repo/dtmi/com/example/mything-2.json",
	"owner": "_generated_diagnostic_collection_name_#0",
	"severity": 8,
	"message": "Miss required properties: schema",
	"startLineNumber": 7,
	"startColumn": 5,
	"endLineNumber": 7,
	"endColumn": 5
},{
	"resource": "/C:/code/temp/scratch-repo/dtmi/com/example/mything-2.json",
	"owner": "_generated_diagnostic_collection_name_#0",
	"severity": 8,
	"message": "dtmi:dtdl:property:schema;2 is not a valid property.",
	"startLineNumber": 11,
	"startColumn": 7,
	"endLineNumber": 11,
	"endColumn": 36
}]

DTDL v2 requires all schema elements to have an id, as reported by the parser:

{
    "@context": "dtmi:dtdl:context;2",
    "@id": "dtmi:test:schemas;1",
    "@type": "Interface",
    "schemas": [
        {
            "@type": "Object",
            "fields": [
                {
                    "name": "rf1",
                    "schema": "integer"
                }
            ]
        }
    ]
}

dtmi:test:schemas;1's property 'schemas' requires an identifer but none provided. Add an '@id' property whose value is a string that conforms to the DTMI syntax -- see https://github.com/Azure/digital-twin-model-identifier.

Current behavior. The Language server does not point this issue
Expected.

• Show the issue in the problems tab
• Squiggles
• Show @id as required in the intellisense drop down

Repro Steps

Create a Device Template in Central
Select Edge Device
Export the device template
Extract each of the interfaces to a different file

Expected: No errors since those are valid DTDL files
Observed:

The DTDL extension complains about the Relationship:

Although the files passes the .NET parser validations

[
  {
    "@id": "dtmi:p8pl7l5ly:capabilitymodel:mybouqmfzo;1",
    "@type": "Interface",
    "contents": [
      {
        "@id": "dtmi:p8pl7l5ly:capabilitymodel:mybouqmfzo:SamplePnPModule;1",
        "@type": [
          "Relationship",
          "EdgeModule"
        ],
        "displayName": {
          "en": "SamplePnPModule"
        },
        "maxMultiplicity": 1,
        "name": "SamplePnPModule",
        "target": [
          "dtmi:p8pl7l5ly:SamplePnPModule;1"
        ]
      }
    ],
    "displayName": {
      "en": "Azure IoT Edge Capability Model mybouqmfzo"
    },
    "@context": [
      "dtmi:iotcentral:context;2",
      "dtmi:dtdl:context;2"
    ]
  },
  {
    "@id": "dtmi:p8pl7l5ly:SamplePnPModule;1",
    "@type": "Interface",
    "displayName": {
      "en": "Module SamplePnPModule"
    },
    "@context": [
      "dtmi:iotcentral:context;2",
      "dtmi:dtdl:context;2"
    ]
  }
]

Per the DTDL spec, properties do not support Arrays, using a model like the one below should report a problem.

For reference, the .NET parser fails with the next error:

dtmi:rido:dictionaries;1 has 'contents' value with name 'AMap' which contains Array, which is not allowed in 'schema' properties under elements of type Property. Remove the elements of type Array from 'schema' properties under the element of type Property.

{
  "@context": "dtmi:dtdl:context;2",
  "@id": "dtmi:rido:dictionaries;1",
  "@type": "Interface",
  "displayName": "dictionaries",
  "contents": [
    {
      "@type": "Telemetry",
      "name": "temperature",
      "schema": "double"
    },
    {
      "@type": "Property",
      "name": "AMap",
      "writable": true,
      "schema": {
        "@type": "Map",
        "mapKey": {
          "name": "mapKey",
          "schema": "string"
        },
        "mapValue": {
          "name": "mapValue",
          "schema": {
            "@type": "Array",
            "elementSchema": "string"
          }
        }
      }
    },
    {
      "@type": "Command",
      "name": "reboot",
      "request": {
        "name": "delay",
        "schema": "integer"
      }
    }
  ]
}

When a model uses a type defined in the IoT Central context but the model does not specify this context, version 1.1.0 detects this condition and reports that the IoT Central context should be added. This is great, but ideally the extension should also provide a "quick fix" to add the missing context. It is merely a simple text substitution.

DTDL: Create Interface always places the new file in the root.

Is it possible to create the new file in the current active folder?

I just loaded this plug-in in visual-studio, and when trying to select a geospatial schema, we are presented with the following error:

However, based on the following it seems as it should be a possible schema (?)
https://github.com/Azure/opendigitaltwins-dtdl/blob/master/DTDL/v1-preview/schemas/geospatial.md

:

Test on v0.2.0
Step:
1.input “” in schemas value and verify the suggestion of auto-completion

Expect: should be no auto-completion suggestion
2.select one item from the suggestion list and verify no diagnostic message to reminder user to input DTMI

Expect:
The pattern of DTMI is dtmi:;. Path may contain only letters, digits, underscore, and colon. Version must be numeric.

There has been a new extension added to DTDL

https://github.com/Azure/opendigitaltwins-dtdl/blob/master/DTDL/v3/DTDL.mqtt.v1.md

that should be supported in this tool

Hello 👋 I'm from the VS Code team.

Recently, we have been exploring a security feature we refer to as Workspace Trust. This feature is intended to centralize and unify a security conscious decision required by a variety of VS Code features. With workspace trust, the user will be able to declare whether or not they trust the folder that is opened in VS Code before these features are executed.

Why you should care

Your extension is incredibly popular with VS Code users! We want to make sure that those users have a delightful experience with workspace trust and that includes extension authors deciding how much of their extension is supported in an untrusted workspace.

Workspace Trust experience

You can enable the feature with the following setting security.workspace.trust.enabled. Once enabled, you will see the following dialog when opening folders in VS Code.

This dialog is important for allowing the user to make a decision early and understand the impact of their decision. Once you understand the feature, you may want to customize when to display the dialog using the setting security.workspace.trust.startupPrompt.

You can follow the development of Workspace Trust and provide feedback in issue #106488.

Workspace trust API

First off, all of what I am about to say can be found in issue #120251. That issue will include discussion of the feature and any updates to the feature.

The Workspace Trust extension API is now in stable. This allowed us to release the first cut of our guide for onboarding your extension to Workspace Trust. The API is small, so here is a quick look.

You can declare your extension to provide complete, partial or no support in untrusted workspaces using the untrustedWorkspaces capability in package.json.

The following example declares that the extension is supported completely in untrusted workspaces. In this case, the extension is enabled in untrusted workspaces.

"capabilities": {
  "untrustedWorkspaces": {
    "supported": true
  }
}

The next example declares that the extension is not supported in untrusted workspaces. In this case, the extension is disabled in untrusted workspaces.

"capabilities": {
  "untrustedWorkspaces": {
    "supported": false
  }
}

The third option is to declared limited support. There are three tools provided to you when you select the limited option.

First, if you have a setting that can be configured in the workspace but requires the workspace to be trusted in order to apply the workspace value, then you can include the setting using restrictedConfigurations array property in untrustedWorkspaces object. Doing so, VS Code will ignore the workspace value of these restricted settings when your extension reads these settings values using the VS Code Workspace Configuration API.

The following example declares the settings that are restricted in untrusted workspaces.

"capabilities": {
  "untrustedWorkspaces": {
    "supported": "limited",
    "restrictedConfigurations": [
      "markdown.styles"
    ]
  }
}

Next, you can also check and listen if the current workspace is trusted or not programmatically using the following API:

export namespace workspace {
  /**
   * When true, the user has explicitly trusted the contents of the workspace.
   */
  export const isTrusted: boolean;
  /**
   * Event that fires when the current workspace has been trusted.
   */
  export const onDidGrantWorkspaceTrust: Event<void>;
}

Lastly, you can hide commands or views declaratively with the isWorkspaceTrusted context key in your when clauses.

A far more detailed guide on how to onboard which will be updated as we receive feedback can be found in issue #120251.

Rollout plan

Workspace Trust will remain disabled for the month of May, but we are planning on enabling this by default in the future. To prepare for that day, we would love for you to try it out and provide feedback.

We'd love your feedback

Since this issue was created in an automated fashion, we won't be monitoring the responses in this issue (our notifications would explode!). Instead we ask you to drop questions, and feedback in issue #120251 as we've mentioned above.

We're excited to see what you do with workspace trust!

Extension shows, that "unit" property of "Property" type is not valid.

According to documentation, unit is optional property of "Property" type
https://github.com/Azure/opendigitaltwins-dtdl/blob/master/DTDL/v2/dtdlv2.md#property

Environment: DTDL v1.2.0

From #91

Central and the Device Model Repository use the expanded format (an array with one item per interface) to import/export models with all the dependencies in the same file.

However this extension does not recognize that format and does not validate the DTDL

In enum values like

          {
            "enumValue": "Compressed Air",
            "name": "Compressed Air"
          },

spaces in "name" attribute are not allowed, but not shown as error in editor.

DTDLValidator output:

*** Error parsing models
Error 1:
dtmi:digitaltwins:rec_3_3:core:Capability:_contents:__phenomenon:_schema:_enumValues:__Compressed Air;1's property 'name' has value 'Compressed Air', which is invalid. Modify the value of 'name' to make it match the regular expression '^[A-Za-z](?:[A-Za-z0-9_]*[A-Za-z0-9])?$'.
Primary ID: dtmi:digitaltwins:rec_3_3:core:Capability:_contents:__phenomenon:_schema:_enumValues:__Compressed Air;1
Secondary ID: 
Property: name

This interface is reported as invalid, although the DTDL parser reports it as correct.

{
    "@context": "dtmi:dtdl:context;2",
    "@id": "dtmi:com:example:dnd:arraysDemos;1",
    "@type": "Interface",
    "contents": [
      {
          "@type": ["Telemetry", "Location"],
          "name": "multiplePoints",
          "schema": "point"
      }
    ]
  }