Repro Steps:

1. Run a command like "Add setting" from the command palette

Two problems:

1. At the environment quick pick, it has "undefined":
   
2. At the next quick pick, it should automatically select "Application Settings", but it's not
   

Depending on a few things, like when you create a new repo or we detect your remote via your git settings, it makes the number of steps in the wizard wonky. Should we just hide this?

Today I'm filtering the production environment out because I felt like it was the same as the app itself. There are some considerations though if we show production under Environments.

The decision to separate the two was because we were following the design pattern of Deployment Slots.

Here is the current UI:

1. Where do we put the App Settings/Configurations Node? Right now I have it as one of the children under the SWA node itself, but it makes more sense to me to remove it from the SWA node and put it in the env node.
2. Including the hostname makes less sense. We have "Browse Site" so I don't really think we need to display it to users anyway. I think we should display the GitHub org/repo in the SWA Node.

Some input from Mitch:

yup you can think of the SWA app as the representation of some application, but the production environment might be just one of many environments in the app

I think showing it would make sense because even if users don't understand the environment concept, I think they will still be confused about why they aren't shown here but if they right click and go to portal they see one

OS: Windows/Mac
Build Version: 20200514.4

Repro Steps:

1. Create a JavaScript project with HttpTrigger function using Functions extension
2. Open this project in VS Code
3. Click the 'Create Endpoint…' button on the ribbon-->JavaScript
4. Check the result

Actual:
There is no logs in "Azure Static Web App(Preview) " for "creating endpoint"

Suggestion:

1. Add the logs in "Azure Static Web App(Preview) " for "creating endpoint"
2. The prompt message that pops up changes to "Finished creating endpoint..." is better.

This needs to support the following from Functions

• CRUD app settings in the explorer
• Support multiple environments (similar to the slots experience)
• Upload local.settings.json 💪

It's just so ugly and unintuitive to me...

Can we just always create one? I feel like we're already pretty opinionated (aka it has to be an http trigger), so why not pick a sensible default for this, too. I can't think of why I'd want an API without an endpoint

NOTE: This is all moot if we do #38

OS: Win10 & Mac
Build Version: 20200514.4

Repro Steps:

1. Install the Static Web Apps Extension from VSIX.
2. Click "Create Static Web App...".
3. Pop up a prompt as the below. --> Click "Allow" -->Open the GitHub page in browser.
   
4. Authorize GitHub for VSCode -->Continue --> Confirm Password
5. Check the result.

Expect:
Authorize successfully.

Actual:
An error occurs.

More Info:

1. It's successful to authorize GitHub for VSCode at second time.
   

2. Back to VS Code, an error dialog pops up.
   

@fiveisprime

The message from Azure is not great at all:

Same deal as microsoft/vscode-azuretools#650

OS: Windows
Build Version: 20200514.4

Repro Steps:
Check the commands in command palette.

Expect:
There are commands for Production and Environment.

Actual:
There is no command for Production and Environment.

via microsoft/vscode-azurefunctions#2096 (review)

We've discussed this offline, but I didn't see an issue for it. 8 feels like a lot of prompts for basic create. We discussed various ideas like using the GitHub remote from their local project or automatically defaulting some of the folders, but each of those could be problematic. Will need further thought

EDIT: Seems like the GitHub org is defaulted to local project, but we're still at 7 steps

This relies on the newest VS Code version since it'll be using the GitHub session authentication code (which is in proposed right now)

Does this occur consistently?
Repro steps:

1. Try to create an api without the functions extension installed

Ideally it would follow the same pattern as App Service connections with Cosmos DB where it directs users to the marketplace if it's not installed

Action: staticWebApps.createNewApi
Error type: Error
Error Message: command 'azureFunctions.createNewProject' not found

Version: 0.1.0-alpha
OS: darwin
OS Release: 19.4.0
Product: Visual Studio Code
Product Version: 1.45.0
Language: en

e._tryExecuteCommand workbench.desktop.main.js:3681:135
file:/workbench.desktop.main.js:3681:16
processTicksAndRejections task_queues.js:85:5

Especially during preview, I'm guessing the list of supported locations will be somewhat small. Would be very helpful if users don't have to play whack-a-mole to figure out which locations work

OS: Windows
Build Version: 20200514.4

Repro Steps:

1. Open a function project in VS Code.
2. Create an endpoint with name 'endpoint1'.
3. Create an endpoint->type a duplicate name 'endpoint1'.
4. Check the validation error.

Expect:
The validation error is clear-"The endpoint name is already exists", like the static web app.

Actual:
The validation error is unclear.

"Browse to site"

I see this helping in two scenarios:

1. I create multiple static web apps from the same project. We should only need to prompt the first time since the project structure probably doesn't change
2. I clone a static web app project from somewhere else. If the VS Code settings are in the repo already, we wouldn't need to prompt. This could be especially helpful for sample projects to avoid user error around selecting the wrong folder

That being said, I'm not sure I want this until we support "Advanced" create so that it's obvious how to bypass the settings if I want to create a static web app for something other than the currently opened workspace.

Related to #19

If you try to create an app for a repo that's already configured, you get a nasty error. That should be a prompt explaining why the app can't be created.

Which no longer requires you to create a reporter and has some GDPR-related fixes. See https://github.com/microsoft/vscode-azurefunctions/pull/2073/files

OS: Windows
Build Version: 0.1.0-alpha

Repro Steps:

1. Clone a repo https://github.com/nturinski/ReactSite to local machine.
2. Open this folder in VS Code.
3. Go to the Azure view->Right click the subscription node->Create Static Web App...->Provide a name for this static web app.

Expect:
The wizard to select the branch.

Actual:
An error "Not Found" occurs.

1. Create a new endpoint
2. Make sure you don't have an 'api' folder set
3. It'll ask you to initialize a Functions project, which runs you through the Functions Project Wizard.

I was also wondering if they don't have an 'api' folder, should we prompt them to direct us to a folder?

OS: Windows
Build Version: 20200514.4

Repro Steps:

1. Right click the Application Settings node for a environment->Upload Local Settings...
2. Check the application settings after uploading.

Expect:
The uploaded settings are added to application settings list.

Actual:
No setting is added to Application Settings list after uploading local settings.

OS: Windows
Build Version: 20200514.4

Repro Steps:
Check the commands for Application Settings.

Actual:
There is no command 'Download Settings...'.

Suggestion:
Add a command 'Download Settings...' for Application Settings.

Borrowing Functions icon currently. We need to update those before release.

Repro steps:

1. Set the GitHub remote of your local project using an ssh url instead of an https url
2. Create a new static web app

Expected: It ignores the GitHub remote (I don't think it's actually worth trying to use the ssh url)

Actual: It errors out:

Action: staticWebApps.createStaticWebApp
Error type: 404
Error Message: Not Found

Version: 0.1.0-alpha
OS: darwin
OS Release: 19.4.0
Product: Visual Studio Code
Product Version: 1.45.0
Language: en

new StatusCodeError request-promise-core/errors.js:32:15
Request.<anonymous> request-promise-core/plumbing.js:104:33
Request.RP$callback [as _callback] request-promise-core/plumbing.js:46:31
Request.callback request/request.js:185:22
Request.emit events.js:203:13
Request.<anonymous> request/request.js:1154:10
Request.emit events.js:203:13
IncomingMessage.<anonymous> request/request.js:1076:12
Object.onceWrapper events.js:291:20
IncomingMessage.emit events.js:208:15
endReadableNT _stream_readable.js:1168:12
processTicksAndRejections task_queues.js:77:11

It doesn't prompt that it will overwrite either. I suspect this is unintended behavior.

Should we either:

1. Make the user provide a unique name
2. Prompt the user if they would like to overwrite their old endpoint

Repro Steps:

1. Create a new static web app
2. When prompted for repository, create a new one
3. After it's done, right click -> "View Properties"

I see repositoryUrl and branch as null

"properties": {
        "defaultHostname": "calm-sea-079a40c1e.azurestaticapps.net",
        "repositoryUrl": null,
        "branch": null,
        "customDomains": [],
        "privateEndpointConnections": []
    },

The theory is that users care more about adding endpoints, not adding some sort of project to contain endpoints. Under the covers, we would have to detect if they have a project already and create one if they didn't. I've always thought about doing this for Functions, but I feel like it's too late to break existing patterns. Since static web apps is already simplifying the functions experience, this might be a good opportunity to simplify it even further.

found 17 low severity vulnerabilities in 23643 scanned packages
run npm audit fix to fix 1 of them.
1 vulnerability requires semver-major dependency updates.
15 vulnerabilities require manual review. See the full report for details.

There's one or two persistent ones that we still have in other repos, but most of these you should be able to fix if you follow microsoft/vscode-azureresourcegroups#8

After creating a web app, we have a button to "Show Actions" which takes them to their repo's GitHub Action page. We should have a context menu item for that as well.

For now, the product name needs to say "preview" so..

Azure App Service Static Apps (Preview) in the explorer.

There's a lot of code specifically for the app settings implementation where I had to copy/paste code from Functions/azuretools. For the sake of time, I didn't properly take them as dependencies. This issue is for tracking those copypasta files.

It just says "Enter the app directory", etc. without saying what those are. I feel like it should have at least a few words describing each.

You actually have more info for one prompt, but only if I delete the default text:

I think having a context menu action to git clone the repo that is connected to that web app and then open that project in VS Code.

I figure the flow could be similar to deploying, where you select a folder, but that's where we'd git clone the project to.

OS: Windows
Build Version: 20200514.4

Repro Steps:

1. Right click the Application Settings node for a environment->Upload Local Settings...
2. Check the output log.

Expect:
There is a log 'Uploaded settings to...'.

Actual:
There isn't a log 'Uploaded settings to...'.

OS: Windows
Build Version: 0.1.0-alpha

Repro Steps:

1. Create a JavaScript project with HttpTrigger function using Functions extension.
2. Open this project in VS Code.
3. Create a new static web app with a new GitHub repository.
4. Click "Show Actions" in the notification.
   

Expect:
Open a Github page that shows the actions running on the repo now.

Actual:
An error occurs.

OS: Windows
Build Version: 20200514.4

Repro Steps:

1. Right click the Application Settings node for a environment->Upload Local Settings...
2. Check the prompt dialog.

Expect:
There is file type in the dialog and we select the .json file successfully.

Actual:
Can't select a .json file when uploading local settings, there is no file type.

When we start a delete, it returns a 202. We should poll the endpoint to make sure it was successfully deleted by confirming it returns 204.

Repro steps:

1. Run a command like "Delete" from the command palette

The quick pick says resource group for a static web app:

OS: Windows
Build Version: 0.1.0-alpha

Repro Steps:

1. Create a JavaScript project with HttpTrigger function using Functions extension.
2. Open this project in VS Code.
3. F1->Azure Static Web Apps: Create New API...->JavaScript->Yes to create an API endpoint (Provide an endpoint name).

Expect:
Succeed to create the new API for the function project.

Actual:
An error "Could not find template with language "JavaScript", version "~3", and id "HttpTrigger"." occurs.

If skip for create an API endpoint, the error shows as below.

Repro steps:

1. Open a local project that has a git remote
2. Create a static web app
3. Enter a name

A few issues:

1. Once you get to the branch step, the back button doesn't work Fixed in #24
2. It's not obvious what it's using when it defaults the org/repo. What if we change the prompt to say Choose branch for repository "EricJizbaMSFT/ReactSite"
   
3. The step count seems off. I feel like it should show "7" from the start, but it only goes from "8" to "7" after I enter the name

OS: Windows
Build Version: 0.1.0-alpha

Repro Steps:

1. Create a JavaScript project with HttpTrigger function using Functions extension.
2. Open this project in VS Code.
3. Click the 'Create Endpoint...' button and provide an endpoint name.

Expect:
Succeed to create the endpoint for the function project.

Actual:
A confusing dialog "The selected folder is not a function project. Create new project?" pops up.

Below startswith patterns are restricted app settings in static web app functions

^APPINSIGHTS_,^APPSETTING_,^AZUREBLOBSTORAGE_,^AZUREFILESSTORAGE_,^AZURE_FUNCTION_,^CONTAINER_,^DIAGNOSTICS_,^DOCKER_,^FUNCTIONS_,^IDENTITY_,^MACHINEKEY_,^MAINSITE_,^MSDEPLOY_,^SCMSITE_,^SCM_,^WEBSITES_,^WEBSITE_,^WEBSOCKET_,^AzureWeb

The flow gives impression that they could be added

OS: Windows
Build Version: 20200514.4

Repro Steps:

1. Create an Azure Static Web App from VS Code.
2. Check the output log.

Actual:
There is no log about 'Creating new static web app...' in output panel.

Suggestion:
Add a log 'Creating new static web app...' in output, such as the logs shows when creating a Function App.