Comments (2)
or prior:
Just staring at that in isolation, it's not clear to me what coordinate system the coord params of
SelectNewRegion(const til::point coordStart, const til::point coordEnd)
are
from terminal.
diff --git a/src/cascadia/TerminalCore/terminalrenderdata.cpp b/src/cascadia/TerminalCore/terminalrenderdata.cpp
index ec28b59d5..3d989f31f 100644
--- a/src/cascadia/TerminalCore/terminalrenderdata.cpp
+++ b/src/cascadia/TerminalCore/terminalrenderdata.cpp
@@ -199,7 +199,7 @@ til::CoordType Terminal::_ScrollToPoints(const til::point coordStart, const til:
_NotifyScrollEvent();
}
- return _scrollOffset;
+ return _VisibleStartIndex();
}
void Terminal::SelectNewRegion(const til::point coordStart, const til::point coordEnd)
this fixes it. Need to write a test
from terminal.
Related Issues (20)
- Buffer restore is created even if "persistedWindowLayout" is not set
- Window layout persisted in `state.json` even if window persistence not enabled HOT 4
- Open new Pane via Keyboard with currently active Profile HOT 3
- Enable dragging tabs to other Windows Terminal Windows HOT 6
- Show current position as starting position inn Windows Terminal Settings Launch Parameters Launch Position HOT 3
- wt.exe windows does not restore correctly after exiting full screen HOT 9
- Cascadia Code arrow segments not displaying correctly HOT 8
- [1.21] Doesn't show the prompt when using "Shell Integration" escape sequences in bash prompt on WSL HOT 3
- Quickly invoking PowerShell menu completion multiple times crashes Terminal
- Splitting pane with shortcut opens wrong terminal session HOT 2
- Different color is displayed when the Cursor color is white in Ubuntu-ColorScheme. HOT 4
- Gaps between block elements when using Direct2D HOT 7
- Shift Double-click in tmux select words from differnet panes HOT 1
- Cursor invalidation failing when line renditions are used HOT 2
- Unlimited zoom-in using Ctrl+Wheel causes renderer to crash HOT 3
- Double wide nerd font glyphs are rendered incorrectly in 1.21 HOT 8
- Cloud shell console loses prompt location HOT 3
- Error trying to use double quotes with git commit -m HOT 2
- PS 7 prompt does not render properly with shell integration profile code HOT 4
- Cursor movement is not always detected on double-width lines HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from terminal.