Giter Club home page Giter Club logo

Comments (2)

zadjii-msft avatar zadjii-msft commented on May 25, 2024

https://github.com/microsoft/terminal/blame/f36d589a8eb60fe9ff4c8efaad8eac088647e8a8/src/cascadia/TerminalCore/terminalrenderdata.cpp#L205-L214

or prior:

https://github.com/microsoft/terminal/blame/d632c39cc3cef3075f09d881e03801518310d641/src/cascadia/TerminalCore/terminalrenderdata.cpp#L171-L207

Just staring at that in isolation, it's not clear to me what coordinate system the coord params of

SelectNewRegion(const til::point coordStart, const til::point coordEnd)

are

from terminal.

zadjii-msft avatar zadjii-msft commented on May 25, 2024
diff --git a/src/cascadia/TerminalCore/terminalrenderdata.cpp b/src/cascadia/TerminalCore/terminalrenderdata.cpp
index ec28b59d5..3d989f31f 100644
--- a/src/cascadia/TerminalCore/terminalrenderdata.cpp
+++ b/src/cascadia/TerminalCore/terminalrenderdata.cpp
@@ -199,7 +199,7 @@ til::CoordType Terminal::_ScrollToPoints(const til::point coordStart, const til:
         _NotifyScrollEvent();
     }

-    return _scrollOffset;
+    return _VisibleStartIndex();
 }

 void Terminal::SelectNewRegion(const til::point coordStart, const til::point coordEnd)

this fixes it. Need to write a test

from terminal.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.