Comments (8)
Unanimous team consent: It's just easier to add builtin glyph support to d2d rather than finagle the SUI to support this
from terminal.
Hi I'm an AI powered bot that finds similar issues based off the issue title.
Please view the issues below to see if they solve your problem, and if the issue describes your problem please consider closing this one and thumbs upping the other issue to help us prioritize it. Thank you!
Open similar issues:
- Box drawing characters are not antialiased (#6161), similarity score: 0.78
Closed similar issues:
- Box drawing characters contain gaps when viewed in Windows Terminal (#14654), similarity score: 0.79
- Box-drawing characters in the Fira Mono font are not connected in the latest preview version of Terminal (#13064), similarity score: 0.77
- Aliased unicode box drawing characters (#13311), similarity score: 0.77
- Unicode box-drawing characters are not rendered in Consolas when font.size < 8 (#12678), similarity score: 0.76
Note: You can give me feedback by thumbs upping or thumbs downing this comment.
from terminal.
It seems that despite the fact that Direct2D provides graphics acceleration, builtin glyphs are not activated in this mode. If this is intended, then it would probably be worth rephrasing the "Builtin Glyphs On/Off" option description, specifically indicating the need for "Direct3D".
terminal/src/renderer/atlas/AtlasEngine.h
Lines 130 to 140 in 49e4eea
terminal/src/renderer/atlas/AtlasEngine.r.cpp
Lines 281 to 299 in 49e4eea
from terminal.
Right... I wrote that "This feature only works when GPU Acceleration is available." text before I added the Graphics API setting (at which time that statement was mostly true), but now that doesn't work anymore of course. The question is, which one is best?
- This feature is only available when the Direct3D Graphics API is used.
- This feature is unavailable when the Direct2D Graphics API is used.
- This feature is unavailable when Direct2D is used for text rendering.
- something else?
from terminal.
It seems to me that since the "Builtin Glyphs" option is completely dependent on the "Graphics API" option, it makes sense to make it a sub-option of the "Graphics API" option that becomes available when "Direct3D 11" is selected.
I don't think the "Builtin Glyphs" option should necessarily be per-profile, as a global option it is quite appropriate for me.
from terminal.
Oof that's a tricky one. Cause I'd expect it on the appearance page, but the renderer option doesn't really need to be on the appearance page. That's definitely an advance option.
Maybe when d2d is enabled, we could disable the builtin glyphs menu item, and add a message box with a deeplink to the advanced page... but that sounds overly complicated.
I guess making it a sub-item of the renderer entry is probably the most elegant solution
from terminal.
I suspect most people will keep it on the default option "Automatic", in which case Direct2D is only used if the system lacks a GPU (or it's a very old GPU, but that's fairly rare nowadays). This is commonly the case when using RDP to remote into a server or VM.
The reason I put the "Builtin Glyphs" option on the profile appearance page is because the font setting is per-profile and so I guess the builtin-glyph option (which overwrites glyphs in the font) should be per-profile too.
The problem is that the settings UI doesn't really have any idea about this "Automatic" API choice. It could be hooked up of course, but I think that's somewhat annoying to do (different DLLs, with different components, on different threads, and it may change at any given moment = needs event hooks). The upside on the other hand is potentially fairly small, because >95% of users are using the Direct3D renderer anyway.
Unless Dustin/Mike think about this differently, I think I'll only change the sub-text on the setting for now. If more people run into this issue (even just a few), I'll try to improve it by hooking up the render thread to the settings UI, or something similar.
from terminal.
I'd love those specific feature toggles to get grayed out when the feature is unavailable for any reason. We could give additional context as to why they're grayed out with a ⓘ button treatment to the grayed-out toggles.
from terminal.
Related Issues (20)
- command line option to launch new windows in zen mode HOT 3
- new windows will only attach to previously used window if terminal is already running HOT 1
- Add an option to see "widthxheight" while resizing a window HOT 3
- Add an option to show notification when copying content
- Unable to find the selected font HOT 1
- Sporadic cannot ctrl+D to or enter to close the terminal HOT 7
- RangeFromPoint and ExpandToEnclosingUnit freezes terminal
- SetConsoleActiveScreenBuffer breaks Unicode output HOT 7
- typeahead no longer works - commands entered while other commands processing in shell are not received HOT 3
- Ability to tell taskbar to take all tabs from all windows terminal windows that are open and list all tabs in 1 list HOT 2
- Two problems with documentation to do with prompts: 1) Oh My Posh might be overkill; 2) the instructions for installing Oh My Posh HOT 1
- using `wt` alias results in silent crash (from explorer url bar, win+r, `wt` in start menu search) HOT 5
- Feature Request: Reverse Command Output Orientation in Windows Terminal HOT 3
- Top of text is cut off when the terminal is in full screen mode HOT 6
- Shared from Edge
- Windows Terminal Translation HOT 3
- sendInput not working with ssh HOT 3
- "duplicate tab" fails due to improper path being sent. HOT 8
- if you re creating cmd terminal why using same looks ? HOT 2
- Optimize Images HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from terminal.