Giter Club home page Giter Club logo

Comments (2)

DHowett avatar DHowett commented on May 24, 2024 1

@NRJank thanks so much for writing this up! I promoted it to a separate bug. The interaction between our new settings, legacy mode, and shortcuts is a place that deserves to be better-explored

from terminal.

zadjii-msft avatar zadjii-msft commented on May 24, 2024

This isn't the culprit, defterm settings aren't saved there:

terminal/src/propsheet/registry.cpp

Lines 949 to 954 in 5f3a857

// Only save the "Terminal" settings if we launched as a v2 propsheet. The
// v1 console doesn't know anything about these settings, and their value
// will be incorrectly zero'd if we save in this state.
// See microsoft/terminal#2319 for more details.
if (gpStateInfo->fIsV2Console)
{

Here we get them into the propsheet

terminal/src/propsheet/console.cpp

Lines 618 to 622 in 5f3a857

//
// Find the available default console/terminal packages
//
LOG_IF_FAILED(DelegationConfig::s_GetAvailablePackages(g_availablePackages, g_selectedPackage));

and here we set it:

terminal/src/propsheet/console.cpp

Line 99 in 5f3a857

LOG_IF_FAILED(DelegationConfig::s_SetDefaultByPackage(g_selectedPackage));

from terminal.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.