Comments (5)
@AvogatoWizardWhisker can you file a new issue for that hang/crash on shutdown? adding your settings & state.json will probably be helpful for debugging. I want to make sure that gets sorted separately before the 1.21 release
from terminal.
Okay first off: The automationPeer.RaiseNotificationEvent
gets called... a lot, on startup. Before I've even opened the window. Shouldn't that get moved into if (_searchbox)
?
from terminal.
We've discussed this over here: #16611 (comment)
I've just started making the changes necessary to fix that.
from terminal.
Mmk, lemme know when you've got a fix ready.
My half assed fix was:
diff --git a/src/cascadia/TerminalControl/TermControl.cpp b/src/cascadia/TerminalControl/TermControl.cpp
index acab82931..1692a981a 100644
--- a/src/cascadia/TerminalControl/TermControl.cpp
+++ b/src/cascadia/TerminalControl/TermControl.cpp
@@ -3569,19 +3569,21 @@ namespace winrt::Microsoft::Terminal::Control::implementation
winrt::fire_and_forget TermControl::_coreUpdateSearchResults(const IInspectable& /*sender*/, Control::UpdateSearchResultsEventArgs args)
{
co_await wil::resume_foreground(Dispatcher());
- if (auto automationPeer{ Automation::Peers::FrameworkElementAutomationPeer::FromElement(*this) })
- {
- automationPeer.RaiseNotificationEvent(
- Automation::Peers::AutomationNotificationKind::ActionCompleted,
- Automation::Peers::AutomationNotificationProcessing::ImportantMostRecent,
- args.FoundMatch() ? RS_(L"SearchBox_MatchesAvailable") : RS_(L"SearchBox_NoMatches"), // what to announce if results were found
- L"SearchBoxResultAnnouncement" /* unique name for this group of notifications */);
- }
- _UpdateSearchScrollMarks();
if (_searchBox)
{
+ if (auto automationPeer{ Automation::Peers::FrameworkElementAutomationPeer::FromElement(*this) })
+ {
+ automationPeer.RaiseNotificationEvent(
+ Automation::Peers::AutomationNotificationKind::ActionCompleted,
+ Automation::Peers::AutomationNotificationProcessing::ImportantMostRecent,
+ args.FoundMatch() ? RS_(L"SearchBox_MatchesAvailable") : RS_(L"SearchBox_NoMatches"), // what to announce if results were found
+ L"SearchBoxResultAnnouncement" /* unique name for this group of notifications */);
+ }
+
+ _UpdateSearchScrollMarks();
+
_searchBox->NavigationEnabled(true);
if (args.State() == Control::SearchState::Inactive)
{
but I've got a consistent repro of the crash, so just lemme know
from terminal.
Crash also occurs when I close Terminal, however it hangs then crashes.
from terminal.
Related Issues (20)
- sixel inside tmux and ssh workaround HOT 3
- Has the automatic switching input method function been canceled? HOT 7
- Original console buffer is not restored when closing a secondary one HOT 14
- Author a new default color scheme (to replace Campbell) HOT 4
- Updated to 1.22.2362.0, and the “Color selection, foreground” commands are MIA HOT 1
- ConPTY inside WSL is broken (e.g. running cmd.exe inside WSL)
- yazi not working in Preview v1.22.2362.0 HOT 3
- cygwin with win32-raw-mode enabled, console consumes all available memory. HOT 7
- Typed input is sometimes wrongly ordered HOT 3
- Incorrect french translation HOT 1
- Incorrect Korean translation
- OpenConsole does not respect Dark Mode - Scrollbars are always white HOT 5
- Build Windows Terminal using clang-cl instead of msvc HOT 1
- Terminal crashes when I click on the mark point. HOT 2
- Add an option to revert to old alpha-based selection colors HOT 1
- [1.22.x] [Unicode] Poor complex script support HOT 5
- Some characters are not displayed in the terminal HOT 5
- Allow user to specify the number of rows or columns to increase or decrease by when resizing pane via keyboard.
- [Bug] Cursor Position Issue on Window Resize with Soft Line Wrapping HOT 1
- [BUG] Unable to scroll upwards HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from terminal.