Comments (9)
Happy to get a PR in for this @zadjii-msft , would the preferred approach be to require choco install vswhere
, just require a version of vswhere
be on the PATH before running razzle or something else?
from terminal.
from terminal.
I have VS2019 and VS2019 Preview installed through the installer and the included VSWhere was not added to my path by default. I can try to locate vswhere
to then locate msbuild
, or just require it be on the path somehow for it to run.
from terminal.
We don't add it to the PATH because it's not an oft-enough used tool. Every directoryt added to PATH merely increases lookup time.
I recommend you acquire vswhere.exe via nuget or chocolatey, as described here. You can use the version we always install to "%ProgramFiles(x86)%\Microsoft Visual Studio\Installer\vswhere.exe" but you're rolling the dice on what features you get. For example, I just resolved a bug against vswhere because someone was using that path and trying to use the -find
parameter that was added later. The only way to be sure you get the features you want is either use the ones we added initially (but that started in 15.2) or acquire it yourself. You can also redist it, which is what build systems like Azure Pipelines do (it's used by various built-in tasks).
from terminal.
Thanks, I just got a version of razzle.cmd
working with the chocolatey version and the -find
parameter actually. It seems a bit heavy handed to put a choco install vswhere
in razzle.cmd
, but that would ensure it's a one step setup process. I'll post a PR in a few hours we can worth though, but on my environment it worked well.
from terminal.
Then why not use nuget? You already are using nuget generally, so put "vswhere" in your .nuget\packages.config file and it will get pulled if needed* whenever nuget restore
is run in the repo. That's what a lot of our repos do - even vswhere itself. You could assume a hardcoded path in your script even, but you'll have to remember to update it if you ever update to a newer version in packages.config. Or do what we do and scan for it.
from terminal.
I have a version started here: #606 but I can't get the build tools v141 working in VS2019. I don't want to mix that into this change so I want to get that sorted out before I make it a real PR.
from terminal.
@khouzam you should be able to close this now that #606 was merged.
from terminal.
Fixed in #606,
Thanks!
from terminal.
Related Issues (20)
- [1.21] clearing marks seems to have regressed
- [1.21] Selecting commands, output with the context menu is totally in the wrong place HOT 2
- Pre-seeded actions from userDefaults.json should be removed after adding IDs
- Selection markers permanently disappear when they are scrolled out of view
- CTRL+Backspace no longer removes whole word in pwsh HOT 3
- We should show an error dialog for outdated MacType versions
- [1.21] Duplicating a pane after changing the settings uses the _old_ settings?
- Cannot move the Find dialog, if it covers a search result HOT 2
- Issues with cursor invalidation in GDI HOT 3
- Reflow behavior on window resize seems broken if the cursor is hidden HOT 3
- Feature Request: Add retro Apple II cursor style HOT 2
- Profiles missing after copying settings to other computer HOT 4
- BUG REPORT HOT 2
- When I use certain tools, I occasionally get printing exceptions. HOT 4
- Remove Command's knowledge of its own keybindings
- Terminal crashes when launched by `start /MAX` HOT 2
- wt.exe --version behaviour HOT 3
- Double-click word selection picks up the RPROMPT from the previous line because word wrapping is hard HOT 2
- No longer use Command.Name for disambiguation
- `OpenConsole.exe` can steal focus from the terminal HOT 9
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from terminal.