Expected Behavior

• No target folder generated for project root

Current Behavior

• target folder

Branch

• master

Your Environment

Not related with environment

Expected Behavior

• User can put credential file on the file system, not only under classpath

Current Behavior

• Credential file cannot be loaded from file system with format: file:xx/xx/xx

Possible Solution

• Support different file protocol prefixes, including: file:xx/xx and classpath:xx/xx

Branch

• master

Your Environment

• Version used:
• Operating System and version (desktop or mobile):
• SDK version:

Expected Behavior

• When all resources are not existings, EventHub sample should create all required resources and the application starts successfully

Current Behavior

• EventHub example fails to start with exception.

org.springframework.cloud.stream.provisioning.ProvisioningException: Event hub with name 'xxx-eventhub-input-destination' in namespace 'xxx-eventhub' not existed
	at com.microsoft.azure.eventhub.stream.binder.provisioning.EventHubChannelProvisioner.provisionConsumerDestination(EventHubChannelProvisioner.java:50) ~[classes/:na]
	at com.microsoft.azure.eventhub.stream.binder.provisioning.EventHubChannelProvisioner.provisionConsumerDestination(EventHubChannelProvisioner.java:23) ~[classes/:na]
	at org.springframework.cloud.stream.binder.AbstractMessageChannelBinder.doBindConsumer(AbstractMessageChannelBinder.java:274) ~[spring-cloud-stream-2.0.0.RC3.jar:2.0.0.RC3]
	.........more
	at org.springframework.boot.SpringApplication.run(SpringApplication.java:1243) ~[spring-boot-2.0.1.RELEASE.jar:2.0.1.RELEASE]
	at com.example.EventHubBinderApplication.main(EventHubBinderApplication.java:19) ~[classes/:na]

2018-07-10 15:15:02.267 ERROR 201284 --- [ask-scheduler-1] o.s.cloud.stream.binding.BindingService  : Failed to create consumer binding; retrying in 30 seconds

org.springframework.cloud.stream.provisioning.ProvisioningException: Event hub with name 'xxx-eventhub-input-destination' in namespace 'xxx-eventhub' not existed
	at com.microsoft.azure.eventhub.stream.binder.provisioning.EventHubChannelProvisioner.provisionConsumerDestination(EventHubChannelProvisioner.java:50) ~[classes/:na]
	at com.microsoft.azure.eventhub.stream.binder.provisioning.EventHubChannelProvisioner.provisionConsumerDestination(EventHubChannelProvisioner.java:23) ~[classes/:na]
	at org.springframework.cloud.stream.binder.AbstractMessageChannelBinder.doBindConsumer(AbstractMessageChannelBinder.java:274) ~[spring-cloud-stream-2.0.0.RC3.jar:2.0.0.RC3]
	at org.springframework.cloud.stream.binder.AbstractMessageChannelBinder.doBindConsumer(AbstractMessageChannelBinder.java:77) ~[spring-cloud-stream-2.0.0.RC3.jar:2.0.0.RC3]
	at org.springframework.cloud.stream.binder.AbstractBinder.bindConsumer(AbstractBinder.java:129) ~[spring-cloud-stream-2.0.0.RC3.jar:2.0.0.RC3]
	at org.springframework.cloud.stream.binding.BindingService.lambda$rescheduleConsumerBinding$0(BindingService.java:154) ~[spring-cloud-stream-2.0.0.RC3.jar:2.0.0.RC3]
	..........more
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) ~[na:1.8.0_171]
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) ~[na:1.8.0_171]
	at java.lang.Thread.run(Thread.java:748) ~[na:1.8.0_171]

Expected Behavior

• ARM sdk hardcode credential files as utf-8, should mention this in README.md

Branch

• master

Your Environment

• Version used:
• Operating System and version (desktop or mobile):
• SDK version:

Expected Behavior

• use @Log instead of add log for each class.

Snapshot Code for Reproduce

public class Test {
    private static final Logger log = LogerFactory.get(Test.class));
}

Branch

• master

Your Environment

• Operating System and version (desktop or mobile):
• SDK version:

Expected Behavior

• Submodule of sample should be the same as parent pom.

Current Behavior

• only 4 included.

Snapshot Code for Reproduce

    <modules>
        <module>spring-cloud-azure-cache-sample</module>
        <module>spring-cloud-azure-storage-sample</module>
        <module>spring-cloud-azure-eventhub-binder-sample</module>
        <module>spring-cloud-stream-eventhub-kafka-sample</module>
    </modules>

Branch

• master

Your Environment

• Version used:
• Operating System and version (desktop or mobile):
• SDK version:

1. Define credentialProvider interface to be implement by configuration properties.
2. A default implementation

Due to resourceGroup is created by User, BI team consider it as the GDPR in-scope.
As we have subscriptionId and installId in telemetry, resourceGroup may provide limited BI data here.
If so, We can remove that from our customEvent.

@warrenzhu25 @yaweiw @yaweiw Any idea or advice is welcome. :)

The implementation of AI logging, use system.err.println. It cannot be disabled outside the package. So
we may need to workaround this, and make them happy.

FYI
AI ConsoleLogger

Branch

• master

Your Environment

• Version used:
• Operating System and version (desktop or mobile):
• SDK version:

1. Check whether we can remove ApplicationInsights.xml.
2. Inject instrument key as build property.

Expected Behavior

• After autoconfiguration prompt redis Cache created, the resource in portal should be available.

Current Behavior

• The availability between SDK and portal is inconsistent.

Possible Solution

• SDK update.

Your Environment

• Version used:
• Operating System and version (desktop or mobile):
• SDK version:

Expected Behavior

• each README.md should show the steps of create azure resource manually, or by our sample code.

Current Behavior

• not very clear

Branch

• master

Your Environment

• Version used:
• Operating System and version (desktop or mobile):
• SDK version:

Your issue may already be reported! Please search before creating a new one.

Expected Behavior

Current Behavior

SLF4J: Class path contains multiple SLF4J bindings.
SLF4J: Found binding in [jar:file:/C:/Users/yaweiw/.m2/repository/org/slf4j/slf4j-simple/1.7.25/slf4j-simple-1.7.25.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: Found binding in [jar:file:/C:/Users/yaweiw/.m2/repository/ch/qos/logback/logback-classic/1.2.3/logback-classic-1.2.3.jar!/org/slf4j/impl/StaticLoggerBinder.class]

Possible Solution

there is dependency in spring-cloud-azure pom.xml:

org.slf4j
slf4j-api

there are other imports to import org.slf4j.Logger

should remove previous one?

This property controls starting from earliest or latest

Spring cloud stream supports consuming from multiple destination, we need to have different storage account container for each destination.

Rename it into pring.cloud.azure.eventhub.namespace since this is not only used for cloud stream

DefaultEventHubClientFactory.createEventProcessorHost should use host name

spring.cloud.azure.enabled=true
spring.cloud.azure.redis.enabled=true
etc

Currently dependencies are not managed in one place, and unnecessary dependencies are introduced. e.g., event hub sample includes service bus dependency, which is introduced from Spring Integration Azure.

When resource is not created, this library will create the resource automatically for the user, as the creation time costs long, adding log to show resource is being created helps the user understands the status.

Following exception thrown by illegal naming:

java.lang.IllegalArgumentException: EventHub names must conform to the following rules to be able to use it with EventProcessorHost: Must start with a letter or number, and can contain only letters, numbers, and the dash (-) character. Every dash (-) character must be immediately preceded and followed by a letter or number; consecutive dashes are not permitted in container names. All letters in a container name must be lowercase. Must be from 3 to 63 characters long.

But the event hub instances can still be created.

https://github.com/Microsoft/Spring-cloud-azure/tree/master/src

Any reason why the project config related files are put under a folder named src?

Branch

• master

Your Environment

• Version used:
• Operating System and version (desktop or mobile):
• SDK version:

Support SQL, MongoDB, Cassandra, Graph API

eventhub binder sample document typo:

1. Running the code sample -> Run

2. Make sure my.azureauth is encoding with UTF-8.

   is encoding -> is encoded

https://github.com/Microsoft/spring-cloud-azure/blob/master/spring-cloud-azure-samples/spring-cloud-azure-cache-sample/src/main/resources/application.properties

spring.cloud.azure.region is not included in the application.properties and also in the README.

Expected Behavior

• should be AzureRedisAutoConfiguration

Current Behavior

• current getClass should be dynamic proxy instance AzureRedisAutoConfiguration$$EnhancerBySpringCGLIB$$126319a1

Possible Solution

• use AzureRedisAutoConfiguration.class and remove AutoConfiguration suffix.

Branch

• master

Your Environment

• Version used:
• Operating System and version (desktop or mobile):
• SDK version:

Current Behavior

• LoggerFactory is not a Logback LoggerContext but Logback is on the classpath.

Possible Solution

• Should exclude logback

Branch

• placeholder

Your Environment

• Version used:
• Operating System and version (desktop or mobile):
• SDK version:

Expected Behavior

• Send message through EventHub sample and should log the received message

Current Behavior

• java.lang.NoClassDefFoundError: org/apache/qpid/proton/reactor/ReactorOptions

java.lang.NoClassDefFoundError: org/apache/qpid/proton/reactor/ReactorOptions
	at com.microsoft.azure.eventhubs.impl.ProtonUtil.reactor(ProtonUtil.java:20) ~[azure-eventhubs-1.0.0.jar:na]
	at com.microsoft.azure.eventhubs.impl.MessagingFactory$ReactorFactory.create(MessagingFactory.java:531) ~[azure-eventhubs-1.0.0.jar:na]
	at com.microsoft.azure.eventhubs.impl.MessagingFactory.startReactor(MessagingFactory.java:122) ~[azure-eventhubs-1.0.0.jar:na]
	at com.microsoft.azure.eventhubs.impl.MessagingFactory.createConnection(MessagingFactory.java:110) ~[azure-eventhubs-1.0.0.jar:na]
	at com.microsoft.azure.eventhubs.impl.MessagingFactory.createFromConnectionString(MessagingFactory.java:201) ~[azure-eventhubs-1.0.0.jar:na]
	at com.microsoft.azure.eventhubs.impl.MessagingFactory.createFromConnectionString(MessagingFactory.java:187) ~[azure-eventhubs-1.0.0.jar:na]
	......more
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) [na:1.8.0_171]
	at org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61) [tomcat-embed-core-8.5.29.jar:8.5.29]
	at java.lang.Thread.run(Thread.java:748) [na:1.8.0_171]

proton-j dependency is introduced by azure-servicebus, version is too old.

[INFO] |     +- com.microsoft.azure:azure-eventhubs-eph:jar:1.0.0:compile
[INFO] |     |  +- com.microsoft.azure:azure-eventhubs:jar:1.0.0:compile
[INFO] |     |  +- com.microsoft.azure:azure-storage:jar:6.1.0:compile
[INFO] |     |  |  \- com.microsoft.azure:azure-keyvault-core:jar:0.8.0:compile
[INFO] |     |  \- com.google.code.gson:gson:jar:2.8.2:compile
[INFO] |     \- com.microsoft.azure:azure-servicebus:jar:1.2.5:compile
[INFO] |        +- org.apache.qpid:proton-j:jar:0.22.0:compile
[INFO] |        +- org.bouncycastle:bcpkix-jdk15on:jar:1.53:compile

Possible Solution

• Make azure-servicebus in parent as optional dependency and only include required dependency for event hub.

Steps to Reproduce (for bugs)

• start event hub sample
• Send post request to post message