microsoft / jfr-streaming Goto Github PK

Is your feature request related to a problem? Please describe.
The problem is that there is some utility code that could be added to the project, but the classes for the utility should not be part of the core library.

Describe the solution you'd like
Make the project use maven modules. The core library (which is today 'src') can be kept separate for other code - utilities or frameworks - that might be built on top of or along side of the core library.

Describe alternatives you've considered
Putting all of the code in 'src' and either letting the utility code be shipped as runtime code, or rig the build to exclude the utility classes from the jfr-streaming jar. The problem with shipping with runtime is that the utility could create vulnerabilities. The problem with excluding the utility classes are many, but the biggest would be that the only way to get the utility would be to build from source. The preference is to be able to have a separate utility library that could be fetched from maven central which makes it a more natural way of using the utility in a build.

Additional context
Relevant to PR 16.

Is your feature request related to a problem? Please describe.
Not related to a problem. Using maven wrapper is considered best practice as it avoids having to rely on what version the user may or may not have installed.

Describe the solution you'd like
Maven wrapper is described here

Describe alternatives you've considered

Additional context