Comments (15)
@chingucoding,
You're welcome to work on this issue :)
from axe-windows.
Thank you for using Accessibility Insights for Windows, @dilyantraykov!
We'd love to offer guidance but need some more information from you:
- It would be most helpful if you could provide an a11yTest file that contains the accessibility errors you are troubleshooting. Please ensure that this file does not contain sensitive or proprietary information.
- The other way to give us the most context possible would be to create a minimal reproduction of the type of error you are seeing in source code for a sample app. This would allow us to run Accessibility Insights for Windows on our end and better understand the case you are trying to address.
- Some background and context around the sparkline control you are using would be helpful. What kind of application are you building? What is the use case for displaying this particular control?
Best,
Madalyn
from axe-windows.
The team requires additional author feedback; please review their replies and update this issue accordingly. Thank you for contributing to Accessibility Insights!
from axe-windows.
BoundingRectangleError.zip
TestResults 10-13-22.zip
Hello Madalyn,
Thank you very much for your response!
Please find attached both a small sample project which demonstrates the error, as well as the test results I observe at my end.
To answer point 3. of your inquiry, the RadSparkline control (for WPF applications) is mainly used by our clients to outline trends. I've hardcoded the data for simplicity, but in the common case, it is generated dynamically.
I hope you find this information sufficient to suggest a viable approach for handling this use case. Please let me know if you require any additional information.
from axe-windows.
You can safely ignore this result. It seems legitimately possible for the bounding rectangle of a sparkline to have an area less than 25 pixels.
from axe-windows.
For those on the A11y Insights team, we should create a heuristic based on the following criteria to avoid running the bounding rectangle area rule on sparklines:
- ItemStatus property matches XPath ""
- ControlType = Custom
We should also move this issue to the axe-windows repo.
Here is the full value of the ItemStatus property:
<?xml version="1.0" encoding="utf-16"?><Properties><Property Name="ActualHeight" Value="1.0204081632653062" /><Property Name="ActualWidth" Value="9.1872000000000025" /><Property Name="DataContext" Value="Telerik.Windows.Controls.Sparklines.SparklineColumnDataPoint" /><Property Name="FlowDirection" Value="LeftToRight" /><Property Name="Focusable" Value="True" /><Property Name="HorizontalAlignment" Value="Stretch" /><Property Name="IsFocused" Value="False" /><Property Name="IsVisible" Value="True" /><Property Name="Language" Value="en-us" /><Property Name="Margin" Value="0,0,0,0" /><Property Name="MaxHeight" Value="Infinity" /><Property Name="MaxWidth" Value="Infinity" /><Property Name="MinHeight" Value="0" /><Property Name="MinWidth" Value="0" /><Property Name="Opacity" Value="1" /><Property Name="Tag" /><Property Name="VerticalAlignment" Value="Stretch" /><Property Name="Visibility" Value="Visible" /><Property Name="Background" /><Property Name="BorderBrush" /><Property Name="BorderThickness" Value="0,0,0,0" /><Property Name="FontFamily" Value="Segoe UI" /><Property Name="FontSize" Value="12" /><Property Name="FontStyle" Value="Normal" /><Property Name="FontWeight" Value="Normal" /><Property Name="Foreground" Value="#FF000000" /><Property Name="HorizontalContentAlignment" Value="Left" /><Property Name="IsTabStop" Value="True" /><Property Name="Padding" Value="0,0,0,0" /><Property Name="TabIndex" Value="2147483647" /><Property Name="VerticalContentAlignment" Value="Top" /><Property Name="Fill" Value="#FF5A6378" /></Properties>
from axe-windows.
This issue has been marked as ready for team triage; we will triage it in our weekly review and update the issue. Thank you for contributing to Accessibility Insights!
from axe-windows.
In today's triage discussion, we agreed to update the Condition
of the BoundingRectangleSizeReasonable
rule to omit WPF controls if their ItemStatus property includes the text <Property Name="DataContext" Value="Telerik.Windows.Controls.Sparklines.SparklineColumnDataPoint" />
from axe-windows.
@DaveTryon @asksep Mind if I work in this issue?
from axe-windows.
This is fixed but we need to keep the bug in the resolved state until we actually release the updated package
from axe-windows.
@dilyantraykov, this has been fixed in Axe.Windows 2.1.0, released today. Please close out at your convenience. Thanks!
from axe-windows.
The team requires additional author feedback; please review their replies and update this issue accordingly. Thank you for contributing to Accessibility Insights!
from axe-windows.
This issue has been automatically marked as stale because it is marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment. Thank you for contributing to Accessibility Insights!
from axe-windows.
Hello team,
Please excuse me for the late response and thank you for the effort in creating a fix.
Although this works in our particular scenario, there are other elements that also exhibit such errors which have a different ItemStatus code. I assume that other vendors may also have such issues with similar elements but their ItemStatus values will differ.
Would it be possible to expose some property or other API to mark certain elements to be ignored for checks on a particular rule?
from axe-windows.
@dilyantraykov, I just saw your request. Adding an API is probably a non-starter. The best way to handle these would be to create a new issue for each class that would potentially fall into this category, then we'll need to evaluate them on a case-by-case basis.
from axe-windows.
Related Issues (20)
- [BUG] Deadlock in TreeWalkerForLive.GetTreeHierarchy HOT 7
- [BUG] Scanning UWP apps crashes since UIAutomation does not find any child elements HOT 8
- [Feature Request] Need Task<ScanResults> IScanner.ScanAsync() HOT 6
- [Feature Request] NativeMethods.SetProcessDPIAware() should be reset after scan HOT 6
- [Feature Request] Localization support in the CI/DI pipeline HOT 5
- CustomUIA settings have some overlap between async scans HOT 2
- [Feature Request] Make scans against Chromium-based UIs more actionable HOT 9
- [BUG] Should NameIsInformative rule filter out more frameworks? HOT 6
- Re-enable Scan_Integration_WebViewSample test in PR build ? HOT 2
- [Feature Request] Provide a way for .a11ytest files to be retained even if a scan produces no errors HOT 6
- Update WiX from v3 to v4 HOT 4
- [Feature Request] Make DefaultActionContext public HOT 5
- [BUG] WinForms edit controls don't support TextPattern until .NET Framework 4.8.1 HOT 2
- [BUG] MSI installer should warn user about unsupported OS HOT 2
- [General Question] How to disable rules HOT 3
- [General Question] False positive for "The Name property must not include the element's control type." HOT 1
- [General Question] Why does axe-windows not include axe-core and its rules? HOT 4
- [BUG] *.yml and *.targets files should contain copyright headers
- [BUG] Axe.Windows files are signed with the 3rd party certificate HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from axe-windows.