Giter Club home page Giter Club logo

Comments (8)

RobGallo avatar RobGallo commented on June 8, 2024

@chingucoding
I think the most reliable way to solve this problem is probably not to call FindAll, but to use an IUIAutomationTreeWalker instead. How do you feel about giving that a try? If you want, I may be able to take a look in the coming days.

from axe-windows.

 avatar commented on June 8, 2024

This issue has been marked as ready for team triage; we will triage it in our weekly review and update the issue. Thank you for contributing to Accessibility Insights!

from axe-windows.

 avatar commented on June 8, 2024

The team requires additional author feedback; please review their replies and update this issue accordingly. Thank you for contributing to Accessibility Insights!

from axe-windows.

marcelwgn avatar marcelwgn commented on June 8, 2024

Sure, I can give that a try. Can you point me to an example of that or the general idea of how this could work @DaveTryon ?

from axe-windows.

DaveTryon avatar DaveTryon commented on June 8, 2024

Hi, @chingucoding!

I opened WinUI 2 Gallery in AIWin, and there are 2 processes here. The topmost process (the child of the desktop) is named ApplicationFrameHost.exe. This process contains the system menu and the minimize/maximize/close buttons.

The second process, AppUIBasics.exe has a window that is a child of window owned by the ApplicationFrameHost.exe process. This the process that we're looking for. As pointed out earlier, we broke this in #676, where we limited the search to direct children of the desktop, rather than allowing the search to go arbitrarily deep.

The original code worked because it did a deep dive, effectively ignoring this note from the remarks section of the API documentation:

When searching for top-level windows on the desktop, be sure to specify TreeScope_Children in the scope parameter, not TreeScope_Descendants. A search through the entire subtree of the desktop could iterate through thousands of items and lead to a stack overflow.

So, to locate the process in question, we need to be able to do the following:

  1. Go at at least 2 levels of depth
  2. Look for elements that are not the first enumerated element
  3. Still be reasonably performant

I wasn't able to locate sample code that does this, so I coded something up. I've created a sample PR of what this might look like. It works locally for both UWP and non-UWP apps. I'm pretty sure that it's leaking memory from not releasing the items in nonMatchingElements. Hopefully that should be fairly easy to sort out, though.

from axe-windows.

 avatar commented on June 8, 2024

The team requires additional author feedback; please review their replies and update this issue accordingly. Thank you for contributing to Accessibility Insights!

from axe-windows.

marcelwgn avatar marcelwgn commented on June 8, 2024

Awesome @DaveTryon , I'll take a look and create a PR then. Please assign this issue to me.

from axe-windows.

DaveTryon avatar DaveTryon commented on June 8, 2024

This was fixed in release 1.1.7

from axe-windows.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.