Regression issue: appId is never set in response headers about applicationinsights-aspnetcore HOT 2 CLOSED

when lastIKeyLookedUp does not match the current items ikey, we trigger a app id lookup, and stores ikey to lastIKeyLookedUp. I believe the issue is relying incorrectly on ApplicationIdProvider to resolve ikey to appid in the very 1st call. its not guaranteed to return app id for the 1st time (because it don't wait for task to complete), but gets it resolved by subsequent calls. The above perf fix prevented asking for appid once lastIKeyLookedUp is set.

This is an issue with actual AppIdProvider, not with a DictionaryProvider. Functional Tests used DictionaryProvider, hence did not catch the issue.

The fix would be to do look up when lastAppIdUsed is null.

from applicationinsights-aspnetcore.

if (this.lastIKeyLookedUp != requestTelemetry.Context.InstrumentationKey)
                    {
                        var appIdResolved = this.applicationIdProvider?.TryGetApplicationId(requestTelemetry.Context.InstrumentationKey, out this.lastAppIdUsed);
                        if (appIdResolved.HasValue && appIdResolved.Value)
                        {
                            this.lastIKeyLookedUp = requestTelemetry.Context.InstrumentationKey;
                        }
                    }

from applicationinsights-aspnetcore.