Giter Club home page Giter Club logo

Comments (6)

msftbot avatar msftbot commented on April 28, 2024

This issue has been marked as ready for team triage; we will triage it in our weekly review and update the issue. Thank you for contributing to Accessibility Insights!

from accessibility-insights-action.

asksep avatar asksep commented on April 28, 2024

PM to determine next steps for UI changes

from accessibility-insights-action.

msftbot avatar msftbot commented on April 28, 2024

This issue requires additional investigation by the Accessibility Insights team. When the issue is ready to be triaged again, we will update the issue with the investigation result and add "status: ready for triage". Thank you for contributing to Accessibility Insights!

from accessibility-insights-action.

asksep avatar asksep commented on April 28, 2024

We will bundle this into feature work: ADO-Improvements -1

from accessibility-insights-action.

brocktaylor7 avatar brocktaylor7 commented on April 28, 2024

I'm not certain we want to pursue this. If the webserver returns a success code the page is scanned. The scanner package does check the status codes and throws if the page doesn't exist. In the case of the user mentioned above, I assume the webserver was serving a page it just happened to be empty? That seems like an edge case that on its own is probably good for the end-user to fix.

The accessibility-insights-scan package doesn't currently have infrastructure for detecting a blank page. If the base URL or a linked page is served successfully with a 200 status code but is blank it will return two failure instances from axe-core:

2 failure instances
* (1) document-title:  Ensures each HTML document contains a non-empty <title> element
* (1) html-has-lang:  Ensures every HTML document has a lang attribute

There is also no way of doing this without modifying the service repo to handle this case. If we were to pursue this further, we would likely want to make it optional with a flag that can be passed into the crawler. We would also have to figure out how to structure the output properly to handle this scenario, as the crawler is expected to return axe results.

This is the last open issue on the ADO-improvements-1 feature. I talked to Rob and he said he was okay with either closing this issue as-is if everyone agrees. Otherwise we'll want to discuss it further and the plan will be to push it to a later feature.

from accessibility-insights-action.

ThanyaLeif avatar ThanyaLeif commented on April 28, 2024

Closed after discussion with the managers.

from accessibility-insights-action.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.