Giter Club home page Giter Club logo

Comments (4)

msftbot avatar msftbot commented on April 28, 2024

This issue has been marked as ready for team triage; we will triage it in our weekly review and update the issue. Thank you for contributing to Accessibility Insights!

from accessibility-insights-action.

msftbot avatar msftbot commented on April 28, 2024

This issue requires additional investigation by the Accessibility Insights team. When the issue is ready to be triaged again, we will update the issue with the investigation result and add "status: ready for triage". Thank you for contributing to Accessibility Insights!

from accessibility-insights-action.

msftbot avatar msftbot commented on April 28, 2024

This issue has been marked as ready for team triage; we will triage it in our weekly review and update the issue. Thank you for contributing to Accessibility Insights!

from accessibility-insights-action.

katydecorah avatar katydecorah commented on April 28, 2024

There are a couple ways to improve the discoverability of the artifacts report:

Improve error message logging

If the action finds errors, it will display a node process exit error message which does not have meaningful context to the user:

Exit code 1 returned from process: file name '/home/vsts/agents/2.206.1/externals/node16/bin/node', arguments '"/home/vsts/work/_tasks/accessibility-insights_dc031a10-21c6-5672-9e59-a8d92a9ba7f4/4.0.0/index.js"'.

Screenshots of current behavior

Email notification error:

screenshot of Azure DevOps email notification with the exit code error message

Pipeline error:

screenshot of Azure pipeline where the exit code error message displays

Suggested fix

We can use the azure-pipe-lines-task-lib setResult to create a custom message, for example:

Scan completed with errors, visit the build's Extensions tab for full details and to download the accessibility report.

This will reduce ambiguity over the error and provide the user with next actions.

Update link text in the summary upload

When you open the extension tab, the link to the artifact's report may not be easily discoverable as it uses "run artifacts" as the link text:

See scan details by downloading the report from run artifacts

Screenshot of current behavior

Azure pipeline Extensions tab:

screenshot of extensions tab

Suggested fix

To improve discoverable, we can update the link text to something more descriptive:

Download the accessibility report

from accessibility-insights-action.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.