Comments (11)
Hi @yinonov, thanks for filling an issue! I believe this is not a bug and is in fact by design. Please check out our docs here, which discuss why Accessibility insights does not support elements that are contained within a closed shadow DOM: https://accessibilityinsights.io/docs/web/reference/faq/#are-automated-checks-compatible-with-shadow-dom
Thanks @sfoslund, this section u shared refers to a closed
mode of shadowRoot, which isn't the case here. Mode is open.
from accessibility-insights-action.
This issue requires additional investigation by the Accessibility Insights team. When the issue is ready to be triaged again, we will update the issue with the investigation result and add "status: ready for triage". Thank you for contributing to Accessibility Insights!
from accessibility-insights-action.
Investigating with engineers
from accessibility-insights-action.
thanks @brocktaylor7 that's exactly what I did
from accessibility-insights-action.
Hi @yinonov, thanks for filling an issue! I believe this is not a bug and is in fact by design. Please check out our docs here, which discuss why Accessibility insights does not support elements that are contained within a closed shadow DOM: https://accessibilityinsights.io/docs/web/reference/faq/#are-automated-checks-compatible-with-shadow-dom
from accessibility-insights-action.
The team requires additional author feedback; please review their replies and update this issue accordingly. Thank you for contributing to Accessibility Insights!
from accessibility-insights-action.
This issue has been marked as ready for team triage; we will triage it in our weekly review and update the issue. Thank you for contributing to Accessibility Insights!
from accessibility-insights-action.
any clue why this happens? does it happen in axe itself?
from accessibility-insights-action.
You are referring to which links are crawled, not which links are scanned, correct?
Not crawling open shadow dom links is a current limitation of accessibility-insights-service).
The most realistic path to picking up links in open shadow DOMs would be switching the service from puppeteer to playwright (which would pierce open shadow DOMs by default with the sort of query apify uses to scrape for links),
Piercing closed shadow DOMs is a lot harder implementation-wise β thatβs functionality that neither Puppeteer nor Playwright facilitate.
This does make sense for us to address long-term. I have filed an issue in the service repo to track the request: #2170.
I will close this issue. But the community should feel free to leave comments in the service tree repo to help us prioritize this change.
from accessibility-insights-action.
Thanks for the detailed explanation.
IN the meantime, I s there a workaround where I could specify a list of links for the action to visit?
from accessibility-insights-action.
Hello @yinonov,
Sorry for the delayed response. There is a mechanism for specifying a list of links for the action to visit.
You can use the input-urls
input in your YAML configuration file to specify the links. The expected value of the input is a string of URLs each separated by a space.
An example of the step with the URLs provided might look something like this:
- name: Scan for accessibility issues
uses: microsoft/accessibility-insights-action@v3
with:
url: https://your-website-url
input-urls: https://your-first-link https://your-second-link https://your-third-link
This will put the four listed URLs in the queue to be scanned first, then any crawled URL will be added to the end of the queue and will be scanned after those first four.
Hopefully that solves your issue for now. Let us know if you have any further questions!
from accessibility-insights-action.
Related Issues (20)
- Consider clarifying service account name and password labels HOT 2
- Cannot add task in a classic pipeline without setting Authentication type
- Add input to adjust the zoom level for the page(s) to be scanned HOT 2
- Emit warning or error when the extension unknowingly scans the login page HOT 2
- Accessibility-insights for azure devops not working and throw exception HOT 6
- ADO extension fails when run in a container: handleRequestFunction failed, { message: 'read ECONNRESET' } HOT 8
- Improve Release pipeline support HOT 3
- My tests keep timing out at 180 seconds despite increasing scanTimeout HOT 10
- ADO Extension should support nested directories for outputDir
- Support authentication against PPE AAD login endpoint HOT 4
- Error: "pQuerySelectorAll is not a function" HOT 3
- Troubling messages in build output
- [Feature request]: Normalize GUIDs in baselines HOT 7
- Problem with inputurls if auth is enabled HOT 2
- `failOnAccessibilityError` does not work with `baselinefile` HOT 1
- Password step of authentication failing in ADO extension HOT 1
- Supporting Single Page App for crawler with # in the inputUrl HOT 1
- Allow for both `failOnAccessibilityError` and `baseline` flags to work at the same time HOT 1
- Navigation timeout is not configurable
- TypeError: Cannot read property 'baseUrl' of undefined HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from accessibility-insights-action.