Giter Club home page Giter Club logo

Comments (11)

jlperkins avatar jlperkins commented on April 28, 2024

Hello! Thanks for reaching out. Would you be able to provide a bit more information about the structure of the pages where the images are displayed? From your example, it seems that you have some html pages which solely display a link to an image. Your example was:
<a href="/images/fullimage.png"><img src="thumbnail.png"></a>
If this is all that's included on the page, you may be able to fix these issues by adding alt text to the thumbnail image and wherever you display the full one, and by ensuring that you have set the language attribute at the top of the page. If I've misunderstood the setup of your html, please feel free to correct me and we can dig deeper into this issue.

from accessibility-insights-action.

msftbot avatar msftbot commented on April 28, 2024

The team requires additional author feedback; please review their replies and update this issue accordingly. Thank you for contributing to Accessibility Insights!

from accessibility-insights-action.

flcdrg avatar flcdrg commented on April 28, 2024

Hi @jlperkins, the original page does contain more HTML than that, and it does include alt text.

For example, the first URL flagged in the screenshot above is a URL for an image linked to on this page - https://david.gardiner.net.au/2015/01/2014-in-review.html

eg. this bit:

<p><a href="/assets/2015/01/wp_20150102_001%5b4%5d.jpg"><img src="/assets/2015/01/wp_20150102_001_thumb%5b1%5d.jpg" alt="Smoke rising from bushfire" /></a></p>

And as I understand it, it isn't https://david.gardiner.net.au/2015/01/2014-in-review.html being flagged, but rather it is https://david.gardiner.net.au/assets/2015/01/wp_20150102_001%5b4%5d.jpg (the direct URL to the image, not a HTML page at all!).

If I load https://david.gardiner.net.au/assets/2015/01/wp_20150102_001%5b4%5d.jpg a browser, and then press F12, I can see what I assume is the browser's internal way of rendering an image file. eg.

image

The HTML I can see there looks pretty much the same as what is being flagged by the action.

from accessibility-insights-action.

flcdrg avatar flcdrg commented on April 28, 2024

To be clear, this is nothing to do with my content. This will be true for any image URL. eg. you can see the same thing for this image (currently linked to from www.microsoft.com)

image

from accessibility-insights-action.

msftbot avatar msftbot commented on April 28, 2024

This issue requires additional investigation by the Accessibility Insights team. When the issue is ready to be triaged again, we will update the issue with the investigation result and add "status: ready for triage". Thank you for contributing to Accessibility Insights!

from accessibility-insights-action.

asksep avatar asksep commented on April 28, 2024

The Accessibility Insights team understands the problem you are experiencing, we are investigating next steps on how to handle these cases where the scanner is scanning some files (non-html) it perhaps should not.

from accessibility-insights-action.

jlperkins avatar jlperkins commented on April 28, 2024

Thank you for following up! I hadn't understood your situation correctly but that makes sense--we don't intend for our accessibility rules to be run against any pages besides HTML. We will investigate further how we will best exclude those pages. Thank you for bringing this to our attention.

from accessibility-insights-action.

karanbirsingh avatar karanbirsingh commented on April 28, 2024

Hi @flcdrg - I took a closer look this week and was hoping you can help. I made this demo repository using the latest action release (v3). I'm unable to reproduce accessibility errors on the image URL itself, only on the home index.html page.

Do you have a link handy to your repository or a modified version of my demo that fails? That would help me debug further. So far I'm seeing valid MIME types when I use the GitHub action to host the website. Thanks!

from accessibility-insights-action.

msftbot avatar msftbot commented on April 28, 2024

The team requires additional author feedback; please review their replies and update this issue accordingly. Thank you for contributing to Accessibility Insights!

from accessibility-insights-action.

msftbot avatar msftbot commented on April 28, 2024

This issue has been automatically marked as stale because it is marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment. Thank you for contributing to Accessibility Insights!

from accessibility-insights-action.

flcdrg avatar flcdrg commented on April 28, 2024

Let me take another look and see if I can still reproduce it.

from accessibility-insights-action.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.