Jest configuration doesn't support pure-ESM packages about accessibility-insights-action HOT 4 CLOSED

I started looking into this and so far found two potential options that will allow this repository to accept pure ESM dependencies with Jest:

1. Introduce babel to transform ESM modules. Adds new dependencies and configurations to maintain.
2. Update tsconfig to allowJs and transform ESM modules. No new dependencies, but as I'm still learning the architecture of this repository, I'm not sure if the change to tsconfig will have any adverse effects.

from accessibility-insights-action.

During triage, the team agreed that the second option (updating tsconfig) is the better option as it has lower overhead. This can move forward once the Node 16 work is in.

from accessibility-insights-action.

but as I'm still learning the architecture of this repository, I'm not sure if the change to tsconfig will have any adverse effects.

In case it's helpful for others: I ended up running yarn && yarn cbuild on main and ran git add -f to each package's dist folder. Then I switched over to branch with the tsconfig updates and ran yarn && yarn cbuild again. This gave me a local diff to see how the change to tsconfig affects the build packages (dist). This was very instructive as I learned I needed to update another setting in shared's tsconfig (to include only the src directory to prevent extraneous js files from change the package directory structure).

from accessibility-insights-action.

This was resolved in #1268

from accessibility-insights-action.