michd / arduino-mcp492x Goto Github PK

Great work, simple API, I like it.

Almost worked the first try, beside the fact that SPI.h is not included from MCP492X.h. I think that it should be. As a "end user", it is natural to me that the library I use include the libraries it needs without having to think about it.

Other small thing in the example (in the readme.md) there is a small error:
MCP492X myDac(PIN_SPI_CHIP_SELECT);
should be
MCP492X myDac(PIN_SPI_CHIP_SELECT _DAC);

I didn't sent much time with those two issues, it was quite obvious.

Thanks

P.S. I am using it with STM32duino https://github.com/rogerclarkmelbourne/Arduino_STM32
chip: stm32F103C8 on a Blue Pill board http://wiki.stm32duino.com/index.php?title=Blue_Pill(cheap chinese board)