michaelbaker / java-tictactoe Goto Github PK

tests, all passing
good separation of concerns
short methods
good method and variable names
all strings in one place
idiomatic Java

GameTest.testPlacingATokenOnATakenSpaceChangesTheToken() communicates to me a situation that should be prevented. Indeed, the game does not allow me to play a square that is already occupied. Why, then, does this test exist?

I like that you wrote some helper methods to simplify some tests.

Names like testHeuristic1, testHeuristic2, etc., aren't as communicative as they could be.

minimize() and maximize() are virtually the same.

When I installed IDEA, I had to configure a JDK for the project. Doing so caused some IDEA file to be modified and show up in git status. Tool/workspace files should be removed from version control and ignored.

Same issue occurred with .class files after I compiled the app.

Likes

• unbeatable
• fast

Dislikes

• UI is a bit compressed
• game doesn't tell me which player won or if the game was a draw
• no space between prompte and move, e.g., Enter your move:b1 instead of Enter your move: b1
• not redrawing the board after an invalid move; really on a problem on a short terminal window where the board can be pushed up out of view
• would've liked a script for running the game so I didn't have to type the java command myself