mia-platform / eslint-config-mia Goto Github PK

Hi, I have encountered unreadable behavior, in my opinion, when reassigning a variable from an object that contains a key with the same name as the variable, for example:

let foo = null
try {
  const response = await apiCall()
  foo = response.foo // eslint error: Use object destructuring.eslintprefer-destructuring
} catch (error) {
  console.error(error)
}

This behavior is managed by prefer-destructuring ESLint rule. The way it is currently set up, it forces you to adjust the code like this:

let foo = null
try {
  const response = await apiCall();
  ({ foo } = response.foo) // No eslint errors
} catch (error) {
  console.error(error)
}

I was wondering if it wouldn't be more readable to adjust the rule to allow the reassignment as shown in the first example.
It could be modified by updating the rule like this:

"rules": {
  ...
  "prefer-destructuring": ["error", {
    "VariableDeclarator": {
      "array": true,
      "object": true
    },
    "AssignmentExpression": {
      "array": true,
      "object": false
    }
  }]	
}

This would not be a breaking change, because both syntaxes will work without throwing ESLint errors.