Comments (3)
I'll check that out sounds like there is room for improvement. Not sure what you mean by the server side piece however, could you elaborate?
from sidekiq-unique-jobs.
To me it sounds like you are after something like https://github.com/tobiassvn/sidetiq so I am closing this issue. The payload is supposed to be cleared when the job is run successfully and only ever kept for the maximum time configured for the payload. As I see it there should be no need to keep the payload after the job has been completed. That is a task for a scheduler.
from sidekiq-unique-jobs.
@mhenrixon Sorry I never responded to this... I never received a github email and forgot about the comment to be honest.
I think the point here is that this gem just ensures no two indentical jobs are queued during a given window, whereas it sounds like it ensures that no two identical jobs will be processed during the same window.
Consider the following (sort of contrived) example: I want to send 1 email (a background job) to a user if their account has received a new notification. But I only want to do this once within a 24 hour period so as to not bombard them with emails. The argument to the job is just the user_id of the user to email.
With the current implementation, after the first email job is processed, the uniqueness check no longer happens. So the user will keep getting emails when new notifications are created (assuming the queues empty quickly).
I saw you updated the docs which may help a bit, but anyway I hope that illustrates where the confusion came from.
from sidekiq-unique-jobs.
Related Issues (20)
- Large retry queue causes reaper to run too slow HOT 3
- 8.0.1 Time on locks & changelog UI is incorrect/wrong HOT 5
- Jobs queued during existing job inherit lock digest HOT 1
- My configuration is correct or not. Because uniq job not remove all job process in sidekiq ?
- Redis server v6.0 compatibility HOT 4
- `while_executing` with `on_conflict: :reschedule` reschedules job when unlock fails HOT 7
- Problems with reaper and long running jobs HOT 10
- Migrate away from deprecated Redis commands HOT 2
- `unlocked` reflection is never called
- Logging::Middleware.context can include empty string as key when lock is not set in job hash HOT 1
- PRIMED key grows indefinitely when job re-queues itself in `after_unlock` callback HOT 1
- until_and_while_executing and lock_ttl: jobs silently dropped HOT 3
- incompatibility with sidekiq-failures HOT 4
- Deprecation Warning: Use of rpoplpush command in Redis HOT 1
- Redis has deprecated the `rpoplpush`command
- Release new gem version with "fix replace deprecated rpoplpush w/lmove" HOT 3
- `while_executing` with `on_conflict: :reschedule` Reschedule job after job execution HOT 7
- Reaper manager registration is subject to race conditions HOT 1
- Should client middleware also be added to the Sidekiq server config? HOT 2
- After sidekiq shutdown (with running job) lock digest is not pushned back HOT 8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sidekiq-unique-jobs.