Giter Club home page Giter Club logo

Comments (3)

mhenrixon avatar mhenrixon commented on July 1, 2024

I'll check that out sounds like there is room for improvement. Not sure what you mean by the server side piece however, could you elaborate?

from sidekiq-unique-jobs.

mhenrixon avatar mhenrixon commented on July 1, 2024

To me it sounds like you are after something like https://github.com/tobiassvn/sidetiq so I am closing this issue. The payload is supposed to be cleared when the job is run successfully and only ever kept for the maximum time configured for the payload. As I see it there should be no need to keep the payload after the job has been completed. That is a task for a scheduler.

from sidekiq-unique-jobs.

tjhosford avatar tjhosford commented on July 1, 2024

@mhenrixon Sorry I never responded to this... I never received a github email and forgot about the comment to be honest.

I think the point here is that this gem just ensures no two indentical jobs are queued during a given window, whereas it sounds like it ensures that no two identical jobs will be processed during the same window.

Consider the following (sort of contrived) example: I want to send 1 email (a background job) to a user if their account has received a new notification. But I only want to do this once within a 24 hour period so as to not bombard them with emails. The argument to the job is just the user_id of the user to email.

With the current implementation, after the first email job is processed, the uniqueness check no longer happens. So the user will keep getting emails when new notifications are created (assuming the queues empty quickly).

I saw you updated the docs which may help a bit, but anyway I hope that illustrates where the confusion came from.

from sidekiq-unique-jobs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.