`while_executing` with `on_conflict: :reschedule` reschedules job when unlock fails about sidekiq-unique-jobs HOT 7 CLOSED

Is that only for blocks? For a rescue ensure scenario in a method, the ensure part would only return something with an explicit return. Are blocks different?

from sidekiq-unique-jobs.

Try this in the console:

from sidekiq-unique-jobs.

If the ensure part would indeed return something it would say "pokus" not "hokus".

from sidekiq-unique-jobs.

In our case I believe this happened:

irb(main):015:0* block = lambda do
irb(main):016:0*   true
irb(main):017:0*   "i don't know the return value" if false
irb(main):018:0* ensure
irb(main):019:0*   false
irb(main):020:-> end
irb(main):021:-> pp block.call
nil
=> nil

If unlock succeeds everything works as you mentioned:

irb(main):022:0* block = lambda do
irb(main):023:0*   true
irb(main):024:0*   "i don't know the return value" if true
irb(main):025:0* ensure
irb(main):026:0*   false
irb(main):027:-> end
"i don't know the return value"
=> "i don't know the return value"

from sidekiq-unique-jobs.

So maybe a different approach to solve this would be

      def execute(&block)
        with_logging_context do
          executed = locksmith.execute do
            yield
          ensure
            callback_safely if locksmith.unlock
          end

          unless executed
            reflect(:execution_failed, item)
            call_strategy(origin: :server, &block)
          end
        end
      end

? To be honest I wasn't aware that the result of the ensure block isn't the return value of the block 😉

from sidekiq-unique-jobs.

Ah now I see your problem doh 🙄

from sidekiq-unique-jobs.

Thank you!

from sidekiq-unique-jobs.