mhauru / ncon Goto Github PK

I would like to add type hinting to the source in order to work better with the linter in my own code that depends on ncon.
Would you be accepting a pull request that edits some of the logic to allow type hinting?

Reason for my question is the following:

if not isinstance(v[0], Iterable):
   # v is not a list of lists, so make it such.
    v = [v]

Those are lines 38 to 40 in the source, such assignments make it very difficult to define a type for v.

In this line:

Here the last index of a and the first index of b are contracted. The result is a tensor with two free indices, labeled by -1 and -2. The one labeled with -1 becomes the first index of the result. If we gave the additional argument forder=[-2,-1] the tranpose would be returned instead.

The last sentence should read:

If we gave the additional argument forder=[-2,-1] the transpose would be returned instead.

(I have fixed the word "transpose")