I'm trying to use findimports with namespace packages (i.e. those which don't have an __init__ in their directory tree) and I'm running into some issues.

First, the directory structure:

$ tree
.
├── Makefile
├── moat
│   └── main
│       └── __init__.py
├── README.md
├── setup.cfg
└── setup.py

There's a ../util directory alongside this one which has much the same structure:

 tree ../util
../util
├── Makefile
├── moat
│   └── util
│       ├── __init__.py
│       ├── times.py
│       └── _yaml.py
├── README.rst
├── setup.cfg
└── setup.py

OK. So when I run findimports on this, I get

$ PYTHONPATH=.:../util/ findimports --ignore-stdlib 
main.__init__:
  anyio
  asyncclick
  util
setup:
  setuptools

Now this is obviously suboptimal, as there's no "util" package and the toplevel isn't "main" either. I have to do

• touch moat.__init__.py
• touch ../util/moat/__init__.py

to get a more reasonable output of

moat.__init__:
  
moat.main.__init__:
  anyio
  asyncclick
  moat.util
setup:
  setuptools

To fix the requirement for the first touch statement I would like an option that tells findimports that it should assume that every dictionary it finds (or that's named on the command line) might be the root of a namespace package. This way the src/whatever style of laying out your source repository would still work unchanged.

Imported modules should be recognized no matter whether they're part of a namespace, i.e. the second touch should not be necessary even if I don't use that special new option.

My Jenkins runs findimports, which produces errors of the form

src/foo.py: could not find datetime
src/bar.py: could not find datetime.date
src/baz.py: could not find datetime.datetime
src/qux.py: could not find datetime.timedelta

Why would it not be able to find the stdlib module?

I cannot reproduce if I run findimports locally on the same project.

Correct me if I'm wrong but I feel that this package doesn't easily cover a default use case which is:

Given I have worked on a project for an amount of time and I have installed different external packages:

• run the package locally and display which external packages are really needed
• optionally produce a requirements file
• optionally add current version as from pip show

Thank you for this package,

Hello all contributors,

It can be seen that there were considerations for MIT license in the beginning of development of this library. However, it was licensed under GPL.

I have raised a request to the owner of this library regarding license change and he has kindly agreed.

However, for this to happen approval is needed from every non-trivial contributor.

Implications fo this change are as follow:

• All new versions are simply licensed under the new license.
• Anyone who needs code licensed under the old license (GPL) can fork the earlier version.

So I am raising this issue for contributors to approve (or not) this request for license change.

Approvals needed for this to happen:

1. @mgedmin
2. @Nicolas-Reyland

Approvals that would make this transition easier:
3. @takos22
4. @jepler
5. @zzzeek
6. @timhoffm

It would be much help if contributors commented their position in this issue.

Regards,
Dominykas

I've just got something like that:

 findimports -dnc <the_package_dir>
Traceback (most recent call last):
  File "/usr/local/bin/findimports", line 11, in <module>
    sys.exit(main())
  File "/usr/local/lib/python2.7/dist-packages/findimports.py", line 832, in main
    getattr(g, opts.action)()
  File "/usr/local/lib/python2.7/dist-packages/findimports.py", line 703, in printImportedNames
    print("  %s" % "\n  ".join(imp.name for imp in module.imported_names))
AttributeError: 'ModuleCycle' object has no attribute 'imported_names'

Also effect of mixing -n with -d (without -c) is not described in help.
When used in following order: -dn then -d is ignored and with-nd then -d is ignored.

I was not able to find any documentation in README file about how to install and run the tool, only its description. Adding some steps may be a good idea.

Hey, thanks for developing this package. It just proved really useful for me :-)

BTW, may I suggest you use "#!/usr/bin/env python" in the shebang? I believe it is more portable.

See: https://stackoverflow.com/questions/6908143/should-i-put-shebang-in-python-scripts-and-what-form-should-it-take

All the best,
G.

Hi,

The pylab import is seen as a py module

Create a file with just that import

[chaen]$ cat /tmp/test.py 
from pylab import hist

Run findimports on it

[chaen]$ findimports /tmp/test.py 
test:
  py

The installed version is 1.5.1

[chaen]$ pip freeze | grep findimports
DEPRECATION: Python 2.7 will reach the end of its life on January 1st, 2020. Please upgrade your Python as Python 2.7 won't be maintained after that date. A future version of pip will drop support for Python 2.7. More details about Python 2 support in pip, can be found at https://pip.pypa.io/en/latest/development/release-process/#python-2-support
findimports==1.5.1

Any idea what is going wrong ?
Thanks !

We should stop using the deprecated compiler module. It also blocks Python 3 support.

See PyCQA/pyflakes@f7626ea for an example of such migration.

I want to display all dependencies of scripts in one folder, including subfolders.

How can I display them, without having them listed per file?

What I would like is to be able to control collapse of sub-packages individually for external dependencies and non-external dependencies in non-package mode.

Maybe there is an easy way to implement it?

By the way.
Nicely written package. This is my goto option for dependency graphs now. Although it's simpler than some alternatives, but it is nicely written and works fast.

Also,
I was just wandering if any work is planned on making nicer outputs for graphviz and/or clustering.

Just met that bug, not a big one because I think my case is special.
In my project folder there is another virtualenv folder and when trying to parse it :

Traceback (most recent call last):
  File "/home/me/myVirtualenv/bin/findimports", line 11, in <module>
    sys.exit(main())
  File "/home/me/myVirtualenv/lib/python3.6/site-packages/findimports.py", line 822, in main
    g.parsePathname(fn)
  File "/home/me/myVirtualenv/lib/python3.6/site-packages/findimports.py", line 427, in parsePathname
    self.parseFile(os.path.join(root, fn))
  File "/home/me/myVirtualenv/lib/python3.6/site-packages/findimports.py", line 454, in parseFile
    module.imported_names = find_imports(filename)
  File "/home/me/myVirtualenv/lib/python3.6/site-packages/findimports.py", line 319, in find_imports
    with open(filename) as f:
FileNotFoundError: [Errno 2] No such file or directory: './localVenv/lib/python3.5/__future__.py'

Is it expected?

E.g. when I run findimports in its own source directory, it tries to parse .tox/py27/lib/python2.7/UserDict.py and fails with a SyntaxError. (I'm running findimports with Python 3.7).

Because getopt is horrible.

Argparse is Teh Future! but optparse works on Python 2.6 which I still support for some reason.