Configurable buttons on changelog dialog about changelog HOT 8 CLOSED

Handler is problematic, but I could define a callback interface that the parent activity needs to implement which will be called if the button is clicked - the standard thing for fragment <-> activity communication...

from changelog.

What do you mean by "Handler is problematic". If it took an callback interface as an input (instead of forcing the parent activity to implement something which does not work very well if your using MVP with a single activity) that would work fine. I was thinking the AlertDialog's neutral or negative button could be leveraged

from changelog.

This is a DialogFragment, no AlertDialog. It survices rotation e.g.... All the data passed to it must be parcelable. That's why the builder is parcelable...

It should be possible to check if the parent activity or the parent fragment implements the callback interface, but that's the only solution I can think of (other than buses or similar, which is not part of the library, and it should work without them as well)

from changelog.

ah yea.. that makes sense

okay so i propose you do the callback interface that the activity would have to support and also add the ability to pass in a fragment that implements the interface as well. Under the hood the activity is only used to get the support manager. As mentioned before my app is a single activity with tons of fragments so i would like to keep all the of the logic for the fragment that is going to show the changelog inside that fragment (or.. well the presenter of the fragment). I believe you can leverage

https://developer.android.com/reference/android/app/Fragment#settargetfragment

to access the fragment that created the dialogfragment

Example:
https://gist.github.com/Joev-/5695813

from changelog.

Would you mind adding this with the callback and create a pull request? Feel free to make it the way you like it, I may make adjustments afterwards... (like support for parent activity, maybe layout adjustments, whatever).

from changelog.

Yeah I can take a stab at it

from changelog.

I added withRateButton(true) and the IChangelogRateHandler, check out this to see the implementation:

And

New feature is added in this release: https://github.com/MFlisar/changelog/releases/tag/1.0.3

from changelog.

PS: v1.0.4 will open the play store link by default, no need to implement the callback if you want this default behaviour

from changelog.