Giter Club home page Giter Club logo

Comments (4)

MFlisar avatar MFlisar commented on July 19, 2024 1

I just released a new version - its 100% kotlin + compose only though but it does what you want out of the box: https://github.com/MFlisar/ComposeChangelog

from changelog.

soenkegissel avatar soenkegissel commented on July 19, 2024

For every new versionCode the library will show an empty box if no changes are put in the changelog.xml - as shown in the screenshot above.

from changelog.

MFlisar avatar MFlisar commented on July 19, 2024

Changelog entries are loaded when the dialog or activity is created - to support what you want this would need to be done before showing the dialog or activity. This was not intended - I never make releases with empty changelogs e.g..

Feel free to add this feature as a pull request though.

The only fast fix I could offer is to add some text like "This version only has internal changes and improvements" or similar as dialog/activity content if the displayed changelog is empty.

from changelog.

jscti avatar jscti commented on July 19, 2024

+1 for this need.

I don't want to spam my users for each one of my minor/fix releases, but only major and/or the ones with new features..
Depends for each apps/developer though

Looked quickly at the code lib and dirtyfixed by adding an IF but it's so ugly (causes an double changelog build) that I won't even do a PR for that ..

public ChangelogDialogFragment buildAndShowDialog(AppCompatActivity activity, boolean darkTheme) {
        boolean shouldShow = checkShouldShowAndUpdateMinVersion(activity);
        ChangelogDialogFragment dlg = null;
        if (shouldShow) {
            if (getRecyclerViewItems(activity).size() > 0) { // <======= HERE
                dlg = ChangelogDialogFragment.create(this, darkTheme);
                dlg.show(activity.getSupportFragmentManager(), ChangelogDialogFragment.class.getName());
            } else {
                Log.i(Constants.DEBUG_TAG, "Showing changelog dialog skipped because changelog to show is empty");
            }

        } else {
            Log.i(Constants.DEBUG_TAG, "Showing changelog dialog skipped");
        }
        ChangelogPreferenceUtil.updateAlreadyShownChangelogVersion(activity);
        return dlg;
    }

from changelog.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.