Autoform hooks onSuccess not working about meteor-autoform HOT 13 CLOSED

There is a PR on this now: Meteor-Community-Packages/meteor-collection-hooks#283

from meteor-autoform.

hi @timsun28 would you mind proving me a short reproducible example?

from meteor-autoform.

I am still investigating, since tests on the one hand do not show siginificant issues but there is also some coverage missing so I currently try to go the test-driven way to find out what's actually going on there

from meteor-autoform.

Hi @jankapunkt ,
I have created a quick demo in this empty project that gives me the same issue as in my personal project:
https://github.com/timsun28/autoform-test

You can pull it directly from the repo and run as usual. I have copied my package lists so you can more easily debug what issue could be causing this.

Hope this helps, thank you!

from meteor-autoform.

I reproduced it but I can't find why it's like that. I will have to do some research and also see if there are uncovered tests.

from meteor-autoform.

Thank you for letting me know, I will also continue to look into it so will update if I find a solution or more info.

from meteor-autoform.

I looked at the package list, and noticed matb33:collection-hooks in there. I recently tried to add that package to a project that was using Autoform's hooks, and had the same problem -- the onSuccess hook stopped firing. That might be a place to start looking.

That project is still using Meteor 2.1.1, though.

from meteor-autoform.

@cheesington Thanks for your message. I also tried the hook from that package and it worked properly for inserts. So i'm now using that function to do my processing, but I would prefer to use the autoform functions again. When I get too it I will try and remove that package as I wasn't actively using it for anything else prior to the issues and report back.

from meteor-autoform.

Yeah, I had to remove the collection-hooks package from the project to get the Autoform onSuccess hook to work again. I was using .after.insert on an unrelated collection, so it took a little while to notice the correlation.

I suspect that Autoform and collection-hooks do some monkey patching of the same code.

Please do report back.

from meteor-autoform.

I can also confirm that by removing the collection-hooks package fixed the issues that I was having. Luckily this wasn't a package that I was actively using for anything, so my issue was quickly resolved.

Hope you can find a fix eventually for this issue or discuss it with the devs from collection-hooks.

from meteor-autoform.

Have there been any progress on resolving this issue? Unfortunately I can not easily remove collectioon-hooks from my app.

from meteor-autoform.

I haven't had the problem anymore since removing the package, but if this is not possible for you, you can try to create a fix for either autoform or collection-hooks by renaming a certain function that causes the issue.

Just some random idea that could be worth looking into, is the order of your package list. You could try to load one before or after the other so that Autoform has priority over the function name. I believe that collection-hooks was overwritting one of the autoform functions on a collection, because for me the colllection-hooks was still working when the autoform wasn't.

Hope you are able to find a solution to your problem!

from meteor-autoform.

Released in v1.1.3

from meteor-autoform.