Giter Club home page Giter Club logo

Comments (9)

jankapunkt avatar jankapunkt commented on May 23, 2024 1

Thanks for this investigation @lynchem
Removing the id is of course not an intended behaviour at all. I will get to the bottom of this and inform you, once it's fixed and added to the PR.

from meteor-autoform.

jankapunkt avatar jankapunkt commented on May 23, 2024

thank you @lynchem is this the correct repo: https://github.com/Eonasdan/bootstrap-datetimepicker ?

Do you activate the modal during the form using a custom mechanism or this part of the mentioned repo? Once I get a reproduction I can fix it asap.

from meteor-autoform.

lynchem avatar lynchem commented on May 23, 2024

Nothing to do with the datetimepicker repo AFAIK and yes, that's the correct repo.
Actually, thinking about it a bit more, this is most likely an issue in how the plugins interact with AF. So in this case there's an atmosphere package https://atmospherejs.com/aldeed/autoform-bs-datepicker which should be creating the datetimepicker.
We have a local modified copy of this package (to fix some TZ issues) so I'll look and see if I can figure anything more

from meteor-autoform.

jankapunkt avatar jankapunkt commented on May 23, 2024

Acutally we have this package also now under the MCP hood: https://github.com/Meteor-Community-Packages/meteor-autoform-bs-datepicker :-) If there is anything causing trouble I could fix that, too. Publishing would be then just a few steps away

from meteor-autoform.

lynchem avatar lynchem commented on May 23, 2024

Right Jan, I'll make a mental note - I should always start with the simplest thing that could be going wrong. 😄

When you create a control like this:

{{> afQuickField id="disbursement-paid-date" name='date'}}

It seems in v7 is replaces the id leaving you with
image

where it used to leave that alone and you'd have
image

I'm guessing I'm not alone in having using the id= field occasionally to reference a control so might be a good idea to leave that as it was. Or add it to the breaking changes. It's simple enough to fix.

I'll change the name of the issue to reflect this.

from meteor-autoform.

jankapunkt avatar jankapunkt commented on May 23, 2024

Hi @lynchem I found and fixed this issue. It has been removed during the rewrite. I reversed this but at the same time also support the id setting mechanism that @pouya-eghbali has introduced. Can you verify it's working now using a local copy of the v7-dev branch? Alternatively I could also publish another rc version.

from meteor-autoform.

lynchem avatar lynchem commented on May 23, 2024

Great. Would be handy if you can publish it. I'll try have a look over the weekend

from meteor-autoform.

jankapunkt avatar jankapunkt commented on May 23, 2024

Published as 6.4.0-rc.7.0.1, you need to set the version explicitly via aldeed:[email protected] or it won't be updated.

from meteor-autoform.

lynchem avatar lynchem commented on May 23, 2024

Ok, I can confirm it's fixed in 7.0.1 🎉

from meteor-autoform.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.