Comments (13)
Great. I'll put together a proposal.
from metal3-docs.
@maelk @dhellmann PTAL.
from metal3-docs.
I like the idea of doing this. I'm not sure about using a command line flag to configure it, but we can work through that.
Is there any reason to limit which labels are copied? What would happen if we just take them all?
from metal3-docs.
Is there any reason to limit which labels are copied? What would happen if we just take them all?
The primary concern is that we may be stepping on labels that are managed by some other entity (this was brought up in the CAPI issue linked). Here CAPM3 would own the set of labels that match the prefix.
Also, the ask is for synchronization and not just a one time copy from BMH to Node on creation; that is, if a label (say my-prefix.metal3.io/rack
) was accidentally removed from the Node, CAPM3 would reapply it; similarly, if the user added/removed a label on a BMH, CAPM3 would ensure the Node was updated appropriately.
from metal3-docs.
I also think this would be a very valuable feature for CAPM3. Would you mind starting a proposal on this ?
from metal3-docs.
If we have consensus that this is a good feature to have, then I can definitely write up a proposal.
from metal3-docs.
Yes, I think we definitely want this. We've been looking at how to do something similar with the hardware-classification-controller output.
It would be ideal if this was a new controller in capm3, so we could import the code into capbm downstream. If not a controller, then maybe a library function we could invoke separately.
from metal3-docs.
@dhellmann @maelk PTAL:
https://docs.google.com/document/d/1qMCkggaLGQLHNPnEVGYjpabSrO-DTvSsr8uIW06W0ck/edit?usp=sharing
from metal3-docs.
@Arvinderpal if that document is ready for review, please move it to a pull request on this repository.
from metal3-docs.
from metal3-docs.
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale
.
Stale issues will close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close
.
/lifecycle stale
from metal3-docs.
Stale issues close after 30d of inactivity. Reopen the issue with /reopen
. Mark the issue as fresh with /remove-lifecycle stale
.
/close
from metal3-docs.
@metal3-io-bot: Closing this issue.
In response to this:
Stale issues close after 30d of inactivity. Reopen the issue with
/reopen
. Mark the issue as fresh with/remove-lifecycle stale
./close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
from metal3-docs.
Related Issues (20)
- Feature: Add a resource to request the execution of a workload on a BareMetalHost HOT 13
- Go through the quick-start and fix/improve things you find HOT 4
- Document Metal3Cluster HOT 4
- Document Metal3Machine and Metal3MachineTemplate HOT 5
- Document Metal3Data and Metal3DataTemplate HOT 5
- Add cover pages for feature sections HOT 3
- Document IP reuse HOT 5
- Document user-data, meta-data and network-data usage with BareMetalHosts HOT 4
- Add API reference HOT 7
- Document unhealthy annotation HOT 5
- Running custom IPA in an environment where thereis no DHCP - preprovisioning image HOT 3
- Troubleshooting guide HOT 4
- Fix dead links at bmc-events.md HOT 3
- Fix dead links at kubebuilder-migration.md HOT 3
- Fix dead links at nodes-machines-and-hosts.md HOT 3
- Fix dead links at capm3-remediation-controller-proposal.md HOT 6
- Fix dead links at foundation-proposal.md HOT 5
- Fix dead links at managing-reviewers.md HOT 3
- Fix dead links at triage.md HOT 8
- Fix dead links at crs_reference.md HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from metal3-docs.