Giter Club home page Giter Club logo

meshery-traefik-mesh's People

Contributors

abhishek-kumar09 avatar acald-creator avatar aisuko avatar akshit42-hue avatar amukayoung avatar anita-ihuman avatar ashiscs avatar asubedy avatar ayushthe1 avatar chadha93 avatar delusionaloptimist avatar dependabot-preview[bot] avatar dependabot[bot] avatar dhruv0000 avatar dinesh9718 avatar girishranganathan avatar gr455 avatar kumarabd avatar kushthedude avatar leecalcote avatar muzairs15 avatar revolyssup avatar samyakshah3008 avatar shreyas220 avatar tangledbytes avatar thebeginner86 avatar unnati914 avatar utkarshmishra12 avatar warunicorn19 avatar xdragon2002 avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

meshery-traefik-mesh's Issues

Enhance E2E tests to use mesheryctl to deploy Meshery

Current Behavior

The tests in https://github.com/meshery/meshery-traefik-mesh/.github/workflows/e2etests.yaml use Kubernetes manifests to deploy Meshery .

Desired Behavior

Edit the workflow to use mesheryctl in deploying meshery.

Implementation

Acceptance Tests

Mockups


Contributor Guides and Resources

Migrate builds to GitHub Actions

Description
This repo (the Meshery adapter for Maesh) is currently being built by Docker Hub (repo)on merge to master.

Once ready, this repo should be configured with GitHub Actions for building and pushing the image to Docker Hub.

Update GH Issue Templates

Enhancement Description
The issue templates in this repo are outdated.

Related Challenges
Copy the issue templates from the layer5io/meshery repo to this repo.

Update README with new Meshery logo

Description
A Meshery logo is available. The old version of the logo used in the README should be displaced.

Expected Behavior
New Meshery logo should displace old logo with:

<a href="https://layer5.io/meshery"><img align="left" src="https://raw.githubusercontent.com/layer5io/meshery/master/ui/static/img/meshery-logo/meshery-logo-light-text.png"  width="25%" /></a>

[CI] add label commenter workflow

Description:

This repository should have the label commenter workflow.
It would run whenever an issue/pr is labelled with one of the targeted labels and comment down any relevant information.

Contributor Reference:

The workflow would use: https://github.com/peaceiris/actions-label-commenter

A sample workflow is defined in: https://github.com/meshery/meshery/blob/master/.github/workflows/label-commenter.yml.

It would also need a sample configuration which is defined in: https://github.com/meshery/meshery/blob/master/.github/label-commenter-config.yml

NOTE:

Add end-to-end tests using service-mesh-pattern file.

Current Behavior

Currently e2e tests in the adapter only run tests for vanilla service mesh installation and for addons.

Desired Behavior

The link below is of an example patternfile that should also be deployed and assertions should be made.
https://github.com/service-mesh-patterns/service-mesh-patterns/blob/master/samples/minimalistiobookinfo.yaml

Implementation

Acceptance Tests

Mockups


Contributor Guides and Resources

[CI] Update Slack.yml and add newcomer-alert workflow

Current Behavior
Currently the slack.yml is outdated. Also there is no automated way of notifying the slack channel when a "good first issue" has been created.

Desired Behavior
Update slack.yml and add newcomer-alert.yml to the Github workflow.


Resources
Add the updated slack.yml file and the newcomer-alert.yml file to the .github/workflow folder.

Files needed:
https://github.com/meshery/meshery-istio/blob/master/.github/workflows/slack.yml
https://github.com/layer5io/layer5/blob/master/.github/workflows/newcomers-alert.yml

[README] Need to add `Community Forum`

Description

README.md is the first file one should read when starting a new project. Our community launched Discussion forum for help seekers; needs to publish it officially on README.md for convenience.

Screenshots

Current behaviour:
image

Desired behaviour:
image

Note:
Need to add only last line for Community Forum

Environment:

  • OS: any [e.g. Ubuntu]
  • Browser: any [e.g. Chrome, Safari]
  • Version: any [e.g. 22]
  • Device: any [e.g. laptop, iPhone 8]

Reference:

[README] Need to fix Slack badge

Description

README.md is the first file one should read when starting a new project. For attractive look, we added some badges also.
But, there's a Slack badge failing, need to fix that.

Example Screenshot

Current Behavior

image

Desired Behavior
image

Environment:

  • OS: any [e.g. Ubuntu]
  • Browser: any [e.g. Chrome, Safari]
  • Version: any [e.g. 22]
  • Device: any [e.g. laptop, iPhone 8]

The slack Logo is not redirecting to the slack link but to the meshery.io/community page

Current Behavior

The slack Logo is not redirecting to the slack link but to the meshery.io/community page

Expected Behavior

Screenshots/Logs

Environment

  • Host OS: Mac Linux Windows
  • Platform: Docker or Kubernetes
  • Meshery Server Version: stable-v
  • Meshery Client Version: stable-v
  • Meshery Adapter Version: stable-v

Contributor Guides and Resources

Golang Lint Check Failure

Current Behavior

See https://github.com/meshery/meshery-traefik-mesh/runs/4768181351?check_suite_focus=true#step:4:22.

This might have to be fixed in MeshKit.


Contributor Guides and Resources

[README] Update README Community Section

Description
The Community section in the README says "Access the Community Drive". There is a new procedure of having this automated based on the individual filling in a community member form

Expected Behavior
Update "Access Community Drive" to "To Access Community Drive, fill Community Member Form"

Screenshots
img

Resources
Refer to the Contributing guide

Environment:

  • Host OS:
  • Meshery Version:
  • Kubernetes Version:
  • Browser:

[bug] adapter panics when deploying

Current Behavior

The adapter gets deployed but panics and dies.

Expected Behavior

Adapter should not panic and work.

Screenshots/Logs

time="2021-09-30T20:32:05Z" level=info msg="Adaptor Listening at port: 10006" app=traefik-mesh-adaptor
time="2021-09-30T20:32:05Z" level=info msg="lstat /.meshery/templates/oam/traits: no such file or directory" app=traefik-mesh-adaptor
time="2021-09-30T20:32:07Z" level=info msg="Registering latest workload components for version v1.3.2" app=traefik-mesh-adaptor
Looking for kubeopenapi-jsonschema in  /root/.meshery/bin
panic: runtime error: index out of range [0] with length 0

goroutine 32 [running]:
github.com/layer5io/meshkit/utils/manifests.getApiVersion(0xc00081d590, 0x29, 0xc000ab86a0, 0x1c, 0xc0009ee1c2, 0xd, 0x1bf5ff3, 0x4, 0x1c0157f, 0xc, ...)
        /go/pkg/mod/github.com/layer5io/[email protected]/utils/manifests/utils.go:172 +0x772
github.com/layer5io/meshkit/utils/manifests.getDefinitions(0xc0009ee1c2, 0xd, 0x0, 0x1c0157f, 0xc, 0xc0006a23c0, 0x6, 0xc0006c9bc0, 0x1, 0x1, ...)
        /go/pkg/mod/github.com/layer5io/[email protected]/utils/manifests/utils.go:22 +0x198
github.com/layer5io/meshkit/utils/manifests.GenerateComponents(0xc000ac0600, 0x5d6, 0x0, 0x1c0157f, 0xc, 0xc0006a23c0, 0x6, 0xc0006c9bc0, 0x1, 0x1, ...)
        /go/pkg/mod/github.com/layer5io/[email protected]/utils/manifests/generateComponent.go:87 +0x4b8
github.com/layer5io/meshkit/utils/manifests.GetFromHelm(0xc0007d33b0, 0x2c, 0x0, 0x1c0157f, 0xc, 0xc0006a23c0, 0x6, 0xc0006c9bc0, 0x1, 0x1, ...)
        /go/pkg/mod/github.com/layer5io/[email protected]/utils/manifests/getComponents.go:25 +0xb8
github.com/layer5io/meshery-adapter-library/adapter.RegisterWorkLoadsDynamically(0xc000044baf, 0x13, 0xc000940e20, 0x1a, 0xc000717e08, 0x1bf6290, 0x5)
        /go/pkg/mod/github.com/layer5io/[email protected]/adapter/oam.go:176 +0x79f
main.registerWorkloads(0x1bf6290, 0x5, 0x1e68200, 0xc0000100c0)
        /build/main.go:184 +0x4fa
main.registerDynamicCapabilities(0x1bf6290, 0x5, 0x1e68200, 0xc0000100c0)
        /build/main.go:165 +0x4d
created by main.main
        /build/main.go:114 +0x6ce

Environment

  • Host OS: Mac Linux Windows
  • Platform: Docker or Kubernetes
  • Meshery Server Version: stable-v
  • Meshery Client Version: stable-v
  • Meshery Adapter Version: stable-v

Contributor Guides and Resources

Logo missing in Adapter Chip in Meshery UI

Description
In the last release of this adapter, the icon in the adapter chip has gone missing.

Expected Behavior
Should show a Traefik Mesh icon.

Screenshots
Screen Shot 2021-04-13 at 9 13 02 PM

Environment:

  • Host OS:
  • Meshery Version: v0.5.2
  • Kubernetes Version:
  • Browser:

Broken image in Welcome message

Current Behavior

The workflow that comments on first-time contributor PR merges has a broken image link. See #222 (comment) for an example.

Screenshots/Logs

Screen Shot 2022-10-05 at 12 52 33 PM


Contributor Guides and Resources

Create contributing.md in meshery-maesh repo

Issue Description
Create contributing.md that points to the central contributing.md in the Meshery repo.

Create a stub CONTRIBUTING.md in each of the repos that essentially say:
β€œYou want to contribute to the project? Yay! We want you to! Visit our centralized instructions for contributing.", where the β€œcontributing” is a hyperlink to the CONTRIBUTING.md in the main meshery repo.

Future Effort
In time, as more contributors join the project, we may need a meshery-community repo that has all this and much more info or to have a community / contributing section in the meshery docs.

Traefik Mesh Version Support?

Current Behavior

When running this adapter (make run), log output says that components for version 2.5.6 is completed. However, this version doesn't appear to be valid.

Screenshots/Logs

Adapter Output

➜  meshery-traefik-mesh git:(master) βœ— make run
DEBUG=true go run main.go
INFO[2022-01-24T20:08:12-06:00] Adaptor Listening at port: 10006              app=traefik-mesh-adapter
INFO[2022-01-24T20:08:12-06:00] Components available statically for version 2.5.6. Skipping dynamic component registeration  app=traefik-mesh-adapter

Traefik Mesh Releases:

$ curl https://api.github.com/repos/traefik/mesh/releases\?per_page | grep tag_name
    "tag_name": "v1.4.5",
    "tag_name": "v1.4.4",
    "tag_name": "v1.4.1",
    "tag_name": "v1.4.0",
    "tag_name": "v1.4.0-rc1",
    "tag_name": "v1.3.2",
    "tag_name": "v1.3.1",
    "tag_name": "v1.3.0",
    "tag_name": "v1.2.0",
    "tag_name": "v1.1.0",
    "tag_name": "v1.1.0-rc2",
    "tag_name": "v1.1.0-rc1",
    "tag_name": "v1.0.0",
    "tag_name": "v0.8.0",
    "tag_name": "v0.7.0",
    "tag_name": "v0.6.0",
    "tag_name": "v0.5.0",
    "tag_name": "v0.4.0",
    "tag_name": "v0.3.0",
    "tag_name": "v0.2.1",
    "tag_name": "v0.2.0",
    "tag_name": "v0.1.0",

Contributor Guides and Resources

Normalise Service Mesh Meshmodel model names to SMP enums

Current Behavior

Desired Behavior

model name should be SMP enum and display-model-name should be human readable sourced from the spreadsheet

Implementation

Acceptance Tests

Mockups


Contributor Guides and Resources

[Security] (CWE-88): Potential HTTP request made with variable url

Current Behavior

This golang security check is failing - https://github.com/meshery/meshery-traefik-mesh/runs/4581108903?check_suite_focus=true with the following details:

[/github/workspace/internal/config/releases.go:70] - G107 (CWE-88): Potential HTTP request made with variable url (Confidence: MEDIUM, Severity: MEDIUM)
    69: 	// #nosec`
  > 70: 	resp, err := http.Get(releaseAPIURL)
    71: 	if err != nil {

Contributor Guides and Resources

README: Add hyperlinks to badges

Description
Some of the badges in this repos readme are missing informative hyperlinks.

Desired Behavior
The badges (and their links) that are used in the Meshery repo's README are a great example of how the badges in this repo can be improved.

Replace the Logo of Layer5 with Meshery in config.yml workflow

Description

Currently, we are using the Logo of Layer5 instead of Meshery. This repository is under the organization Meshery, so, there should be the image of Meshery.

How to resolve this?

  • Go to .github and replace this welcome image with the new one:

  • Make sure to display the images conditionally, based on the theme selected by user.
    Here's the sample code:

<picture>
  <source media="(prefers-color-scheme: dark)" srcset="https://raw.githubusercontent.com/GiorgosXou/Random-stuff/main/Programming/StackOverflow/Answers/70200610_11465149/w.png">
  <source media="(prefers-color-scheme: light)" srcset="https://raw.githubusercontent.com/GiorgosXou/Random-stuff/main/Programming/StackOverflow/Answers/70200610_11465149/b.png">
  <img alt="Meshery Logo" src="">
</picture>

New images are:

Meshery-celebration-Light
Meshery-celebration-Dark

  • Download these images, and upload with an appropriate name. Make sure to use conditional rendering as described above.

  • After uploading the image, and removing the previous image, go to .github/config.yml folder and update the reference to previous image to the new image in the following part:

firstPRMergeComment: >
  Thanks for your contribution to the Layer5 and Meshery community! :tada:
   
  ![Congrats!](https://raw.githubusercontent.com/meshery/meshery.io/master/.github/welcome/Layer5-celebration.png)
  &nbsp; &#9; &nbsp; &#9;  &nbsp; &#9;  &nbsp; &#9; :star: Please leave a [star on the project](../stargazers). :smile:

Here, replace ![Congrats!](https://raw.githubusercontent.com/meshery/meshery.io/master/.github/welcome/Layer5-celebration.png) with the code

<picture>
  <source media="(prefers-color-scheme: dark)" srcset="https://raw.githubusercontent.com/GiorgosXou/Random-stuff/main/Programming/StackOverflow/Answers/70200610_11465149/w.png">
  <source media="(prefers-color-scheme: light)" srcset="https://raw.githubusercontent.com/GiorgosXou/Random-stuff/main/Programming/StackOverflow/Answers/70200610_11465149/b.png">
  <img alt="Shows a black logo in light color mode and a white one in dark color mode." src="https://user-images.githubusercontent.com/25423296/163456779-a8556205-d0a5-45e2-ac17-42d089e3c3f8.png">
</picture>

make sure to change the image sources with the path to image in the folder where you upload it.

  • That's it.

Contributor Guides and Handbook

[CI] Define end-to-end integration test assertions

Current Behavior

The following end-to-end integration test workflow has an incomplete definition of test assertions -

# osm-bootstrap: $(jq '.pods_status."osm-bootstrap"' data.json)
# osm-controller: $(jq '.pods_status."osm-controller"' data.json)
# osm-injector: $(jq '.pods_status."osm-injector"' data.json)

Desired Behavior

Define end-to-end integration test assertions

Acceptance Tests

Passing/failing results should show in Meshery Docs compatibility matrix - https://docs.meshery.io/project/compatibility-matrix (this portion of the workflow is complete already).


Contributor Guides and Resources

[Patterns] Component Generation

Description
Component generation is failing.

Expected Behavior
Components should dynamically generate and register with Meshery Server

Screenshots/Logs

time="2021-09-29T17:48:14Z" level=info msg="Listing Operations" app=traefik-mesh-adaptor
time="2021-09-29T17:48:14Z" level=info msg="Creating instance" app=traefik-mesh-adaptor
time="2021-09-29T21:10:46Z" level=info msg="Adaptor Listening at port: 10006" app=traefik-mesh-adaptor
time="2021-09-29T21:10:46Z" level=info msg="lstat /.meshery/templates/oam/traits: no such file or directory" app=traefik-mesh-adaptor
time="2021-09-29T21:10:48Z" level=info msg="Registering latest workload components for version v1.3.2" app=traefik-mesh-adaptor
Looking for kubeopenapi-jsonschema in  /root/.meshery/bin
time="2021-09-29T21:10:49Z" level=info msg="exit status 1" app=traefik-mesh-adaptor
time="2021-09-29T21:11:24Z" level=info msg="Creating instance" app=traefik-mesh-adaptor
time="2021-09-29T21:11:24Z" level=info msg="Listing Operations" app=traefik-mesh-adaptor

Screen Shot 2021-09-29 at 4 12 28 PM

Environment:

  • Meshery Version: v0.5.62
  • Adapter Version: v0.5.10

Contributor Resources

The meshery.io website uses Jekyll and GitHub Pages. Site content is found under the master branch.

Provisioning failure

Description

Details
error applying helm chart: Error applying helm chart: Error applying helm chart: rendered manifests contain a resource that already exists. Unable to continue with install: ClusterRole "prometheus" in namespace "" exists and cannot be imported into the current release: invalid ownership metadata; label validation error: missing key "app.kubernetes.io/managed-by": must be set to "Helm"; annotation validation error: missing key "meta.helm.sh/release-name": must be set to "traefik-mesh"; annotation validation error: missing key "meta.helm.sh/release-namespace": must be set to "default"

Environment:

  • Meshery Version:
➜  ~ mesheryctl version
Client Version: 0.5.0-rc3 	  GitSHA: e6d67a91d0004a3a6a8ba92a8aeb83d9018c4f2a
Server Version: edge-latest 	  GitSHA: d624ec5
Checking for latest version of Meshery...

  0.5.0-rc3 is the latest Meshery release.

[CI] Support multi-platform Docker images

Current Behavior

Desired Behavior

Meshery users, particularly those running Docker Desktop can benefit from multi-platform images of Meshery Server.

Implementation

Refactor existing stable and edge build and release workflows to use docker-build-push actions. See https://github.com/meshery/meshery/blob/master/.github/workflows/build-and-release-dde.yml as an example.

Be aware of local binaries and their needs:

  1. layer5/kubeopenapi-json

Acceptance Tests

  1. platform: linux/amd64,linux/arm64 should both be supported.

Mockups


Contributor Guides and Resources

Traefik Mesh Adapter not successfully registering

Current Behavior

In v0.6.0-rc-4, this adapter's logs state that it has registered with Meshery Server. Meshery Server, though, shows no signs of this registration either in the UI or in the /api/system/adapters response.

Screenshots/Logs

Adapter Logs

➜  ~ k logs -n meshery meshery-traefik-mesh-59c748d8f4-n96x5
time="2022-01-19T22:39:07Z" level=info msg="Adaptor Listening at port: 10006" app=traefik-mesh-adaptor
time="2022-01-19T22:39:07Z" level=info msg="lstat /.meshery/templates/oam/traits: no such file or directory" app=traefik-mesh-adaptor
time="2022-01-19T22:39:08Z" level=info msg="Registering latest workload components for version 2.5.6" app=traefik-mesh-adaptor
Looking for kubeopenapi-jsonschema in  /root/.meshery/bin
time="2022-01-19T22:39:14Z" level=info msg="Latest workload components successfully registered." app=traefik-mesh-adaptor

Screenshot

Screen Shot 2022-01-19 at 3 48 48 PM


Contributor Guides and Resources

Update go version in github actions workflows to 1.17

Current Behavior

Many of places in the workflows still mention go version 1.16 yet the adapters use go version 1.17

Desired Behavior

Workflows shouls also use go version 1.17

Implementation

Acceptance Tests

Mockups


Contributor Guides and Resources

[CI] No image for layer5/meshery-traefik-mesh on docker hub

Description

Running docker pull layer5/meshery-traefik-mesh results in:

Using default tag: latest
Error response from daemon: manifest for layer5/meshery-traefik-mesh:latest not found: manifest unknown: manifest unknown

Running docker pull layer5/meshery-traefik-mesh:stable-latest results in:

Error response from daemon: manifest for layer5/meshery-traefik-mesh:stable-latest not found: manifest unknown: manifest unknown

Expected Behavior

docker pull layer5/meshery-traefik-mesh:stable-latest should be able to pull in the image successfully.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.