Enhancement Description
Support multiple versions in the OSM adapter.

Related Challenges

• Currently the OSM adapter only installs OSM v0.6.0. We need to be able to fetch binaries for the latest releases and use the latest OSM.
• Also, when reading binaries from ~/.meshery/bin it expects them to be in the form osm-v0.6.0. This is a side effect of point one but should be kept in mind.

Alternatives
Using docker cp $binPath meshery_meshery-osm_1:/root/.meshery/bin/osm-v0.6.0 for tricking the adapater to believe that the current binary is for osm-v0.6.0. Too hacky.

Contributor Resources

The meshery.io website uses Jekyll and GitHub Pages. Site content is found under the master branch.

• See the Contributing to Meshery.io Website section of the readme.md and other contributing instructions, too.
• See Meshery site designs in this Figma designfile. Fill-in the Layer5 Community Member Form and join the Layer5 Community Slack for access.

The conformance test task is crashing with the latest release and takes the whole container down.

Description
The issue templates in this repo incorrectly reference labels like bug and enhancement.

Expected Behavior
These issue templates should be updated to reference the new label names like kind/bug and kind/enhancement

Description

Update Issue labels to make it easy to highlight issues with appropriate tags.

Description
The Error check is failing in OSM adapter builds.

Expected Behavior
This error should not occur - https://github.com/layer5io/meshery-osm/runs/1028245941?check_suite_focus=true

Description
The Community section in the README says "Access the Community Drive". There is a new procedure of having this automated based on the individual filling in a community member form

Expected Behavior
Update "Access Community Drive" to "To Access Community Drive, fill Community Member Form"

Screenshots

Resources
Refer to the Contributing guide

Enviroment:

• OS: [e.g. Ubuntu]
• Browser: [e.g. Chrome, Safari]
• Version: [e.g. 22]
• Device: [e.g. laptop, iPhone 8]

Description

We have used port 10010 for osm and there is no 10009

Expected Behavior

Let's not skip a port number and use 10009 for meshery-osm

Description

Enhancement Description
A brief description of the enhancement.

We need the custom service-mesh configuration checking feature for meshery-osm.

Related Challenges
A brief description of what the problem is. (e.g. I need to be able to...)

[Optional] Alternatives
A brief description of any alternative solutions or features you've considered.

[Optional] Additional context
Add any other context or screenshots about the feature request here.

Description
Change notification statement and option names

Enhancement Description
Port meshkit errors to the new error utility function. Instructions covered here, meshery/meshkit#48

Enhancement Description

Support OSM Installation using the adapter like it is available for other adapters

Description
Beta version of this adapter is released in Meshery v0.4.2 is reporting:

meshery-osm_1       | time="2020-08-17T04:12:10Z" level=error msg="unable to create kubeconfig: open /root/.kube/config: no such file or directory"

Enviroment:

• OS: MacOS
• Browser: Safari
• running Docker Desktop

Description

README.md is the first file one should read when starting a new project. For attractive look, we added some badges also.
But, there's a Slack badge, need to fix that.

Example Screenshot :-

Current Behavior

Desired Behavior

Environment:

• OS: any [e.g. Ubuntu]
• Browser: any [e.g. Chrome, Safari]
• Version: any [e.g. 22]
• Device: any [e.g. laptop, iPhone 8]

Enhancement Description

• OSM will seek to be SMI Conformant.
• The Meshery adapter for OSM should support invocation of this operation (of the SMI Conformance test suite)

Desired State:
Open Service Mesh adapter should be listed as an alpha status adapter on https://meshery.io

Contributor Resources

• Meshery documentation site
• Meshery documentation source
• Instructions for contributing to documentation

Description
The operation to apply custom configuration should show under that category, not the Provisioning / Deprovisioning category.

Screenshots

Current Situation
The adapter is using a new TCP port. This needs to be released in conjunction with a new Meshery release.

Description
OSM Adapter operations are thread unsafe at the moment due its usage of meshery-adapter-library viper config provider.

Expected Behavior
Operations should be thread safe. This is achievable by replacing meshery-adapter-library config provider implementation with meshkit config provider implementation which share similar interfaces.

Contributor Resources
Refer Istio Adapter to see how config provider can be replaced

Description
The "Opens Service Mesh" menu item is a broken link.

Expected Behavior

1. Show "Open Service Mesh" in the menu item name.
2. Navigate to http://localhost:9081/management?adapter=meshery-osm:10010

Description
In the last release of this adapter, the icon in the adapter chip has gone missing.

Expected Behavior
Should show an OSM icon.

Screenshots

Environment:

• Meshery Version: v0.5.2

Enhancement Description
The current deployment of the Learn Layer5 tool within the adapter for OSM assumes a cloud-based deployment by specifying a service type of LoadBalancer.

Related Challenges
Kubernetes deployments that require NodePort needs to be supported as well.

Current Situation
Each of the layer5 repositories needs releaseDrafter automation as had been done in the meshery project which takes care of drafting release notes.

Desired Situation
Add ReleaseDrafter configuration yaml file & GitHub Action.

Additional context
Release drafter configuration file
Rlease drafter Github action

Enhancement Description
Like other service meshes, Open Service Mesh has a sample application used to demonstrate its functionality.

The Meshery Adapter for OSM should support the project's sample application, Book Buyer: https://github.com/openservicemesh/osm/tree/main/demo

Current Situation
The build process for this adapter has failing static golang checks - https://github.com/meshery/meshery-osm/runs/4352711502?check_suite_focus=true

Desired Situation
No checks should be failing.

Contributor Resources

The meshery.io website uses Jekyll and GitHub Pages. Site content is found under the master branch.

• See the Contributing to Meshery.io Website section of the readme.md and other contributing instructions, too.
• See Meshery site designs in this Figma designfile. Fill-in the Layer5 Community Member Form and join the Layer5 Community Slack for access.

Current Behavior

Currently, the issue templates only consist of a basic structure.

Desired Behavior

Update the templates to reflect the proper guidelines. Refer: Layer5 Issue templates.

Current Situation
Failure - https://github.com/layer5io/meshery-osm/runs/1019846887?check_suite_focus=true

@kushthedude do you mind having a look into this?

Enhancement Description
A brief description of the enhancement.

As we discussed we should replace meshery-osm adapter to use meshey-kit and meshery-framework as primary dependencies. So I'm going to work on meshery-osm adapter @kumarabd @leecalcote @mgfeller

Related Challenges
A brief description of what the problem is. (e.g. I need to be able to...)

[Optional] Alternatives
A brief description of any alternative solutions or features you've considered.

[Optional] Additional context
Add any other context or screenshots about the feature request here.

Description

build-args main.version=$VERSION and main.gitsha=$GIT_COMMITSHA are not being picked up.

Expected Behavior

when testing locally e.g. building using
GOPROXY=direct GOSUMDB=off go build -ldflags="-w -s -X main.version=VERSION -X main.gitsha=GIT_COMMITSHA" -a -o ./meshery-osm .

and running ./meshery-osm

expected result of grpcurl --plaintext 127.0.0.1:10009 meshes.MeshService.ComponentInfo

{
  "type": "adapter",
  "name": "OPEN_SERVICE_MESH",
  "version": "VERSION",
  "gitSha": "GIT_COMMITSHA"
}

Current Situation
This adapter currently has a go report card of a "D".

Desired Situation
Get this go report card to an "A" by following the instructions on this page - https://goreportcard.com/report/github.com/layer5io/meshery-osm

Description

Update the README.md file to stay in accordance with the Meshery repo README.

Description
Deleting OSM installation produces:

exit status 1

Description

README.md is the first file one should read when starting a new project. Our community launched Discussion forum for help seekers; needs to publish it officially on README.md for convenience.

Screenshots

Current behaviour:

Desired behaviour:

Note:
Need to add only last line for Community Forum

Environment:

• OS: any [e.g. Ubuntu]
• Browser: any [e.g. Chrome, Safari]
• Version: any [e.g. 22]
• Device: any [e.g. laptop, iPhone 8]

Reference:

• Take reference to this pull request

Current Behaviour
Error codes utility runner workflow is not present.

Desired Behavious
Add the error codes utility runner workflow.

Instructions in meshery/meshery-linkerd#213

Current Situation
The ReleaseDrafter utility (GitHub Action) is not configured in this repository.

Desired Situation

• Releasedrafter should be configured to execute whenever a PR is merged to master in this repo.

Implementation

• Copy the releasedrafter config and the releasedrafter workflow file from the meshery repo and place in the .github folder here.

We are using logrus in all of our projects, it would be great to have meshery-osm use logrus for the default logging.

Current Behavior
A welcome bot has been configured to usher in contributors new to this project. However, a reminder to star the project is missing in the message.

Desired Behavior
The config.yml should be updated, you can take a cue from the highlighted line 22

[Optional] Alternatives
A brief description of any alternative solutions or features you've considered.

[Optional] Additional context
Add any other context or screenshots about the feature request here.

Description
The CI for docker build and push seems to be passing even when some of the stages are not being triggered.

Expected Behavior
Ideally this should result in a failure during these instances.

Screenshots

Enhancement Description
OSMMesh workloads, which are used for installing OSM, should have more properties.
This would allow users to have more control over configuration when they install the service mesh.

Some Considerations

• Since we're using helm charts for installing OSM, these properties should ideally be extracted from their Values file https://github.com/openservicemesh/osm/blob/main/charts/osm/values.yaml
• We'll need to version these workloads.
• We'll need to figure out how this will keep up with the CLI fallback method.

Description
Static analysis failing due to istio reference - https://github.com/layer5io/meshery-osm/pull/73/checks?check_run_id=2141526807#step:4:21

Current Behavior
Community guidelines, including the contributing guide and the code of conduct is missing.

Desired Behavior
Migrate the contributing guide and the code of conduct from the Layer5 repository.

Current State:

There is no PR template and contributor has to manually populate the details

Desired State:

Add pull-request template for the repository

Contributor Resources

• Meshery documentation site
• Meshery documentation source
• Instructions for contributing to documentation

Enhancement Description

To generate the workflow of getting the manifest from the OSM using the kubeopenapi-jsonschema to read and generate json schemas from those manifests and then also generating workload definitions from those schemas

A sample workflow is here

Description
This repository should have the label commenter workflow.
It would run whenever an issue/pr is labelled with one of the targeted labels and comment down any relevant information.

Contributor Reference

The workflow would use: https://github.com/peaceiris/actions-label-commenter

A sample workflow is defined in: https://github.com/meshery/meshery/blob/master/.github/workflows/label-commenter.yml.

It would also need a sample configuration which is defined in: https://github.com/meshery/meshery/blob/master/.github/label-commenter-config.yml

NOTE:

• In the above configuration https://github.com/meshery/meshery/blob/88d1c7c559259775ce2affab2a15a32c673c3f52/.github/label-commenter-config.yml#L26-L41 are specific to Meshery and won't be needed on every repository.
• Do comment in PR if you find any label is missing for the repo.

Current Behavior
See meshery/meshery#1270 for additional details and the meshery/meshery#284 epic.

Desired Behavior
Implement in the same fashion that has been done in layer5io/meshery repo.