merschformann / gotz Goto Github PK

gotz doesn't output correctly on the windows release (and I think I know why).

Here is a screenshot of a default configuration running with the local time being Eastern Standard:

Here is a command-line bork on a manual entry:

Now, I'm not a go developer but it's a lovely language and easy to follow. In configuration.go and in args.go there is use of the time::Location.LoadLocation(name) function.

Docs state:

LoadLocation looks for the IANA Time Zone database in the following locations in order:

• the directory or uncompressed zip file named by the ZONEINFO environment variable - on a Unix system, the system standard installation location - $GOROOT/lib/time/zoneinfo.zip - the time/tzdata package, if it was imported.

Windows doesn't have an IANA database and also doesn't run a ZONEINFO env var. But, what's this about time/tzdata?

This package will be automatically imported if you build with -tags timetzdata.

I think the easiest fix is in your build script, if you add -tags timetzdata to line 23? Maybe you don't want to do that for unix systems, maybe add another variable and add it with the name change on line 19?

In any case, I love simple TUI command-line tools and yours is spiffy. I love using them as practice to learn or reinforce languages and I'm porting gotz to .NET in F# and C# and I hope to have the F# port done in another day or so. :)

Would it be possible to have the bars shown inline with the labels? I find it hard to read when the bars are underneath. Maybe something like this:

                                                                   now v 07:47
                                                                        | 
Local : Thu 28 Jul 2022 07:47                               ▒▒▒▒▒▒████████████████████████████████████████████████▒▒▒▒▒▒▒▒▒▒▒▒
                                                                        | 
SF    : Thu 28 Jul 2022 07:47                            ▒▒▒▒▒▒████████████████████████████████████████████████▒▒▒▒▒▒▒▒▒▒▒▒
                                                                        | 
IST   : Thu 28 Jul 2022 20:17 ▒▒▒▒▒████████████████████████████████████████████████▒▒▒▒▒▒▒▒▒▒▒▒      

I'd like to keep gotz opened and glance at it without running the command. Ideally this is a flag or configuration value with maybe a sane update interval that can also be configured. I don't need 60 FPS for this, for example, or even every second. Minutes?

I like the idea of creating a known-good config file at startup, but replacing the user's custom config file with the defaults when a syntax error has been found seems very aggressive. It means the user is just one typo away from having their carefully tailored configuration getting blown away without warning. Since I'm posting this, I bet you can probably guess what just happened to me...

It seems safer behavior would simply be to exit with an error message if the configuration file cannot be parsed. At the very least, the user should be given the chance to cancel before their custom configuration is replaced.