Giter Club home page Giter Club logo

prevent-window-opener-attacks's People

Contributors

ernscht avatar jantimon avatar oliverdietsche avatar reeko avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

prevent-window-opener-attacks's Issues

workaround no longer needed: All major browsers automatically fix the issue by adding rel=noopener automatically if the target attribute is set to _blank

'Marcos Imbuerger' described the underlying issue very well back in 2019. Since the beginning of 2021 this bug seems to bo fixed for modern browsers as pointed out on Stackoverflow with reference to chromestatus.com. The target=_blank Anchor does imply rel=noopener in all modern browsers by default. Quote: "All current versions of major browsers" now automatically fix this issue by automatically adding the behavior of rel="noopener" for any target="_blank" link. The new browser behaviour will be nullifying this issue.

Safari Issue

Hello! Nice work on your library here. I wanted to let you know that I used your github page as a way to test an internal tool I am developing as well for window.opener. I found a bug around safari that I wanted to let you know about. It turns out that setting window.opener = null (which is also the same in my current implementation) does not actually work if the new window is a different origin. In fact when you do call window.opener = null in this scenario you get an error in the console TypeError: null is not an object Which I think is actually a red-herring error. I think it's actually hiding a cross origin security error.

So with that, we both have a bug, and I am not sure what the solution looks like yet. Will let you know if I get a good answer

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.