Comments (5)
Yes. I think that sounds like a good change. I agree that RuntimeWarning
stronger than needed. Since we test changes in the develop
branch in preparations for releases, could you set up a PR in that branch?
Then either myself, @turbosheep or @jianlins will review it and get it in.
from medspacy.
@burgersmoke (since you seem active here): I have a local fork that I've patched this in. Let me know if you agree I can open a PR.
from medspacy.
Awesome. I've opened this PR address the issue: #231
from medspacy.
Thank you @jkgenser . This has been merged into the develop
branch now. We're working on our next release, so this will be in the next release, but not sure when that will be released.
from medspacy.
close as it is resolved
from medspacy.
Related Issues (20)
- Tutorial and Documentation Clarification HOT 1
- Update CI to include more python versions HOT 2
- Need to separate branches' CI from master HOT 2
- rush_rules.tsv issues HOT 6
- Postprocessor does not currently run all rules HOT 1
- error when trying to add medspacy_pyrush sentencizer to pipeline HOT 3
- Clean up Windows-only QuickUMLS code (if we use pysimstring) HOT 1
- ConText: Docs out of date regarding custom attribute modifiers
- Switch to medspacy_quickumls so that Windows can automatically install QuickUMLS HOT 1
- Possible bug with "negative for" context rule HOT 2
- Medspacy Model saving and loading HOT 2
- Please clarify relationship between MedSpaCy release numbers and beta vs. production releases HOT 1
- Remove lingering references to beta in docs/readmes/etc
- Disambiguated spans HOT 3
- Latest pip install issue related unqlite
- quicksectx-0.3.7/setup.py No such file or directory HOT 6
- PyRuSH-1.0.8.tar.gz - Installing build dependencies: finished with status 'error' HOT 2
- Medspacy Installation Issue v1.1.2 HOT 18
- Medspacy-ing in another language HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from medspacy.