mediassumani / cs-2.2-graphtheory Goto Github PK

Challenge 2 Feedback: 5 /20
Overall: Looks like you have a good start, but haven't finished the challenge. Not reading from a file means none of your graph code can be run so you aren't getting credit for it. See challenge 1 solution for help on this.

Feedback based on Challenge 2 Rubric

• Works: ( 2 x 0) = 0

  • challenge 2 file has BFS - but does not read from a file or print.
  • bfs code does not compute a shortest path - just traverses the - graph.

• Documentation: 2

  • Add docstrings to all functions, e.g. add_many_edges, read_file
    In docstrings, include a clear description of function's purpose, input/output, and runtime
  • run pycodestyle to see PEP8 errors around whitespace and line length - PEP8 naming is ok.

• Organization: 2

  • Code in graph is good. Challenge 2 file should just read the graph and print the output and not have a bfs method since this is in graph.

• Testing: 1

  • code has no tests
  • error handling code in graph methods good - make sure to add to file reading (when it is written) and the bfs method.

Challenge 3 Feedback
Overall: 5 /24 : Resubmit with a working dfs , tests and documentation to get a passing grade.

Feedback based on Challenge 3 Rubric:

• Read & output 0/4
  • Does not read from file - output is hardcoded based on sample data.
• Graph class 2/4
• DFS 1/4
  • there is a recursive . dfs - but it is not called.
• Code organization 1/4
  • Don't import code from challenge 1. Use separate files for Graph class and file read method.
• Testing 0/4
  • no tests provided
• Documentation 1/4
  • Thank you for crediting Interview Cake - make sure you do this for any inspiration code and that you always redo in your own code.
  • not all methods have docstrings.

Challenge 1 Feedback: 3/20
Feedback based on Challenge 1 Rubric

• Solution: 0

  • Code does not run on sample input file without errors

• Documentation: 1

  • Add docstrings to all functions, e.g. add_many_edges, read_file
  • In docstrings, include a clear description of function's purpose, input/output, and runtime

• Organization: 2

  • Code should get edge list from the graph itself, not directly from the file
  • Functions should have clear responsibilities, e.g. read_file should return either a graph or an edge list

• Testing: 0

  • Add unit tests for Vertex, Graph, file parsing